Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpackagist package names incorrectly resolved #8

Open
strarsis opened this issue Sep 11, 2017 · 2 comments
Open

wpackagist package names incorrectly resolved #8

strarsis opened this issue Sep 11, 2017 · 2 comments

Comments

@strarsis
Copy link

strarsis commented Sep 11, 2017

@tomjn: Thanks for this very helpful plugin! I is a great timesaver for Bedrock based sites.

Some package names are incorrectly resolved. - Examples:

  • google-analytics-dashboard-for-wp-gadwp should be google-analytics-dashboard-for-wp
  • text-blocks should be reusable-text-blocks
  • updraftplus-backuprestore should be updraftplus
  • wordfence-security should be wordfence
  • yoast-seo should be wordpress-seo

The plugin name in wordpress.org plugin directory is apparently also used by wpackagist.

@tomjn
Copy link
Owner

tomjn commented Sep 11, 2017 via email

@tomjn
Copy link
Owner

tomjn commented Sep 13, 2017

hmm it doesn't use the folder name actually:

https://github.com/tomjn/composerpress/blob/master/php/plugin/wordpressplugin.php#L17

It does use the composer name if a composer.json is found though. plugin_dir_path could be used to figure out the folder name or file name and use that instead though, @strarsis you good to do a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants