Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onRegionChangeComplete wrong second parameter #243

Open
mp3por opened this issue Sep 9, 2022 · 2 comments
Open

onRegionChangeComplete wrong second parameter #243

mp3por opened this issue Sep 9, 2022 · 2 comments

Comments

@mp3por
Copy link

mp3por commented Sep 9, 2022

You are passing a wrong parameter to onRegionChangeComplete from the MapView. It has to be const details = { isGesture }; but you are passing an array of markers.

Please pass the correct 2nd parameter or update the documentation to show this decision and provide a way to know if the it was a gesture update or not.

I (and many others probably) need to know if the update was user-initiated or not.

Possible solution
image

I created a PR

@kivancimer
Copy link

I see the same issue but I dont see the PR

@Falco26
Copy link

Falco26 commented Sep 14, 2023

You are passing a wrong parameter to onRegionChangeComplete from the MapView. It has to be const details = { isGesture }; but you are passing an array of markers.

Please pass the correct 2nd parameter or update the documentation to show this decision and provide a way to know if the it was a gesture update or not.

I (and many others probably) need to know if the update was user-initiated or not.

Possible solution image

I created a PR

did you find a solution to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants