You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you for the well made library! I started using Holy loader in my app and it is triggered in situations when it's not appropriate given the UI context. In my case, I usually use router push transitions for navigation between pages, and replace for things like updating a query parameter that defines sorting, opening a modal window, and similar transitions that don't feel like navigation to the user, and are often instant.
For these reasons it would feel better to skip the loader in replace transitions. I'm thinking this could be a new feature, controlled by a boolean prop like skipReplaceTransitions. No breaking changes necessary as the default behaviour can stay the same.
Should I create a PR with this feature? What do you think about this approach in general?
The text was updated successfully, but these errors were encountered:
Big plus one to this; would love a skipReplaceTransitions option otherwise it just gets noisy for when the page doesn't actually change beyond query params changing
First of all, thank you for the well made library! I started using Holy loader in my app and it is triggered in situations when it's not appropriate given the UI context. In my case, I usually use router
push
transitions for navigation between pages, andreplace
for things like updating a query parameter that defines sorting, opening a modal window, and similar transitions that don't feel like navigation to the user, and are often instant.For these reasons it would feel better to skip the loader in
replace
transitions. I'm thinking this could be a new feature, controlled by a boolean prop likeskipReplaceTransitions
. No breaking changes necessary as the default behaviour can stay the same.Should I create a PR with this feature? What do you think about this approach in general?
The text was updated successfully, but these errors were encountered: