Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blocks): newline handling in MixTextAdapter and paste middleware #8821

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(blocks): newline handling in MixTextAdapter and paste middleware #8821

merged 1 commit into from
Nov 28, 2024

Conversation

lawvs
Copy link
Collaborator

@lawvs lawvs commented Nov 27, 2024

Fix #8816

Also related to #8575

Revert and adjust newline insertion logic to improve text handling in the MixTextAdapter and clipboard paste functionality.

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 2:08am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 2:08am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0c3cc78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 27, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@lawvs lawvs force-pushed the fix/paste-newline branch from be12f88 to 0a4aa4d Compare November 27, 2024 14:03
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 27, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0c3cc78. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@lawvs lawvs force-pushed the fix/paste-newline branch 2 times, most recently from 7409f12 to 5d722ea Compare November 27, 2024 14:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2024 •
edited
Loading

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.08 MB (+0.02% 🔺)
@blocksuite/affine/block-std 156.59 KB (0%)
@blocksuite/affine/block-std/gfx 80.15 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.87 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.22 KB (0%)
@blocksuite/affine/inline 32.09 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.87 MB (-0.02% 🔽)
@blocksuite/affine/blocks 1.96 MB (+0.02% 🔺)
@blocksuite/affine/blocks/schemas 88.56 KB (0%)

@lawvs lawvs force-pushed the fix/paste-newline branch from bb5c786 to 226d04c Compare November 27, 2024 14:56
@lawvs lawvs requested a review from fourdim November 27, 2024 15:21
@lawvs lawvs marked this pull request as ready for review November 27, 2024 15:29
@lawvs lawvs requested a review from a team as a code owner November 27, 2024 15:29
@fourdim fourdim added the merge label Nov 28, 2024
@fourdim Graphite App
Copy link
Contributor

fourdim commented Nov 28, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 27, 9:06 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 27, 9:06 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 27, 9:11 PM EST: A user merged this pull request with the Graphite merge queue.

@lawvs
fix(blocks): newline handling in MixTextAdapter and paste middleware (#…
0c3cc78 
…8821)

Fix #8816

Also related to #8575

Revert and adjust newline insertion logic to improve text handling in the MixTextAdapter and clipboard paste functionality.
@graphite-app graphite-app bot merged commit 0c3cc78 into master Nov 28, 2024
36 checks passed
@graphite-app graphite-app bot deleted the fix/paste-newline branch November 28, 2024 02:11
@fourdim fourdim mentioned this pull request Nov 28, 2024
Closed
1 task
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@fourdim fourdim fourdim approved these changes

Assignees

@lawvs lawvs

Labels
merge
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

​代码框会吞掉拷贝的字符串的最后一个回车符
2 participants
@lawvs @fourdim