Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(database): sum shows too many digits after decimal point #8833

Merged
merged 6 commits into from
Dec 5, 2024
Merged

fix(database): sum shows too many digits after decimal point #8833

merged 6 commits into from
Dec 5, 2024

Conversation

OlegDev1
Copy link
Contributor

Fixes #8815
Fixes floating-point precision error, when calculating the sum of the column

I can write some unit tests, but unfortunately there are no unit tests in data-view folder. Any guidance will be highly appreciated

Before the fix:
Screenshot 2024-11-30 at 13 44 42

After the fix:
Screenshot 2024-11-30 at 13 44 53

@OlegDev1 OlegDev1 requested a review from a team as a code owner November 30, 2024 12:52
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0b0ec99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite 🛑 Canceled (Inspect) Dec 5, 2024 8:38am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 8:38am

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 30, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel Vercel
Copy link

vercel bot commented Nov 30, 2024

@OlegDev1 is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

@Flrande Flrande requested a review from zzj3720 December 2, 2024 07:14
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 2, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0b0ec99. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@Flrande Flrande added the merge label Dec 2, 2024
@Flrande Graphite App
Copy link
Member

Flrande commented Dec 2, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Dec 2, 3:36 AM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 2, 3:36 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 2, 3:36 AM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).
  • Dec 2, 11:14 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 2, 11:19 PM EST: The merge label 'merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Dec 2, 11:19 PM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).
  • Dec 2, 11:21 PM EST: A user added this pull request to the Graphite merge queue.

@graphite-app graphite-app bot removed the merge label Dec 2, 2024
@OlegDev1
Copy link
Contributor Author

OlegDev1 commented Dec 2, 2024

Thank you for starting the merging process of my PR! I have updated my branch to the latest changes

If any changes / additions are required - please let me know, I am happy to help!

@fourdim fourdim added merge and removed merge labels Dec 3, 2024
doodlewind
doodlewind reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sign the CLA for helping us land this PR? Thanks!

@OlegDev1
Copy link
Contributor Author

OlegDev1 commented Dec 3, 2024

@doodlewind I have signed the CLI, thank you very much!

Could you please provide some good first issues?
I really love the flexibility and speed of Affine and want to help with development process. The fact that separate component library was developed specifically to meet Affine's needs is very impressive. I can write tests, fix bugs, or anything. Thanks!

@vercel vercel bot temporarily deployed to Preview – blocksuite December 5, 2024 08:38 Inactive
doodlewind
doodlewind reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Landed the patch, thanks for your contribution!

@doodlewind doodlewind merged commit a98c474 into toeverything:master Dec 5, 2024
2 of 3 checks passed
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Merged
OlegDev1 added a commit to OlegDev1/blocksuite that referenced this pull request Dec 7, 2024
@OlegDev1 @zzj3720
fix(database): sum shows too many digits after decimal point (toevery…
af5d1fb 
…thing#8833)

Co-authored-by: 3720 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

@zzj3720 zzj3720 zzj3720 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

​Sum function prints too many digits after decimal point
5 participants
@OlegDev1 @Flrande @doodlewind @zzj3720 @fourdim