Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blocks): inconsistent language list behavior on hover in Firefox #8944

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(blocks): inconsistent language list behavior on hover in Firefox #8944

merged 1 commit into from
Dec 12, 2024

Conversation

OlegDev1
Copy link
Contributor

@OlegDev1 OlegDev1 commented Dec 11, 2024 •
edited
Loading

Fixes #8565
Language list in code block didn't work as intended in Firefox. This issue was caused by the use of Infinity in sorting algorithm which leads to inconsistent behavior across different browsers

Before (firefox only)

Screen.Recording.2024-12-11.at.17.23.00.mov

After

Screen.Recording.2024-12-11.at.17.23.17.mov

@OlegDev1 OlegDev1 requested a review from a team as a code owner December 11, 2024 16:28
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 4a42f22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:30pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 4:30pm

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024

@OlegDev1 is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 11, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 11, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4a42f22. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Saul-Mirone
Saul-Mirone approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@Saul-Mirone Saul-Mirone merged commit 1876df2 into toeverything:master Dec 12, 2024
38 checks passed
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saul-Mirone Saul-Mirone Saul-Mirone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

​The control buttons for code blocks are not working properly on Firefox.
2 participants
@OlegDev1 @Saul-Mirone