Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting Xenocrypt doesn't make the language Spanish by default #542

Closed
toebes opened this issue Jul 11, 2024 · 0 comments
Closed

Selecting Xenocrypt doesn't make the language Spanish by default #542

toebes opened this issue Jul 11, 2024 · 0 comments
Assignees

Comments

@toebes
Copy link
Owner

toebes commented Jul 11, 2024

Background

Related to #501, if you select Xenocrypt from the Test Generation Tools menu, it defaults the cipher language to English when it should be Spanish

Steps to reproduce:

  1. Go to any cipher and then select Xenocrypt from the Test Generation Tools menu

image

This will take you to /XenocryptEncrypt.html?cipherType=aristocrat

  1. Notice that the language is English. However it should be Spanish by default when going through the menu.

Compare it to going to Xenocrypt from the main page which correctly sets the language
image

This takes you to /XenocryptEncrypt.html?cipherType=aristocrat&curlang=es

Probable Problem

I believe that the problem is in JTAppendSubMenu
https://github.com/toebes/ciphers/blob/master/app/common/jtmenu.ts#L33-L35
which is not appending the value of the lang field to the computed href

SuperIronDragon added a commit to SuperIronDragon/ciphers that referenced this issue Aug 20, 2024
Fixed the issue where when selecting Xenocrypt from the drop down menu, it doesn't set the language to Spanish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants