Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github/workflows/tests: Add Windows platform #313

Closed
wants to merge 1 commit into from
Closed

github/workflows/tests: Add Windows platform #313

wants to merge 1 commit into from

Conversation

rico-chet
Copy link

@rico-chet rico-chet commented Jul 18, 2020 •
edited
Loading

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • N/A If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • N/A Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #XX reference to the issue that this pull request fixes.

@karbassi
Copy link
Member

@rico-chet great idea.

Can you make sure it runs and works?

@rico-chet
Copy link
Author

Oops, this PR is accidental right now, I actually wanted to see what happens when I add windows-latest as platform.
I am writing a bug, so this can be worked on as usual.

@rico-chet rico-chet mentioned this pull request Jul 18, 2020
Open
@karbassi karbassi linked an issue Jul 18, 2020 that may be closed by this pull request
Tests failing on Windows (GitHub Actions) #314
Open
@karbassi
Copy link
Member

karbassi commented Aug 4, 2021

Related to #352

@karbassi karbassi closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests failing on Windows (GitHub Actions)
2 participants
@rico-chet @karbassi