Should not print error if the file attempting to delete does not exist for bcsymbolmap

[christophercotton]

When doing the first download, it seems like the "Delete of the bcsymbolmap" causes an error to be printed.

Reproduction Steps:

1. Create a Romefile with Alamofire
2. Do the build, and upload the files.
3. Do rome download

** Expected behavior**
Will download the needed files and display:

Downloaded Alamofire from: swift5.1.2/Alamofire/iOS/Alamofire.framework-4.8.2.zip
Downloaded Alamofire.dSYM from: swift5.1.2/Alamofire/iOS/Alamofire.framework.dSYM-4.8.2.zip
Downloaded Alamofire.F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap from: swift5.1.2/Alamofire/iOS/F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap-4.8.2.zip
Downloaded Alamofire.3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap from: swift5.1.2/Alamofire/iOS/3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap-4.8.2.zip

Observed behavior:

Downloaded Alamofire from: swift5.1.2/Alamofire/iOS/Alamofire.framework-4.8.2.zip
Downloaded Alamofire.dSYM from: swift5.1.2/Alamofire/iOS/Alamofire.framework.dSYM-4.8.2.zip
Downloaded Alamofire.F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap from: swift5.1.2/Alamofire/iOS/F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap-4.8.2.zip
Error: no such file Carthage/Build/iOS/F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap
Downloaded Alamofire.3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap from: swift5.1.2/Alamofire/iOS/3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap-4.8.2.zip
Error: no such file Carthage/Build/iOS/3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap

It looks like in the line:

Rome/src/Caches/S3/Downloading.hs

Line 182 in 3279870

deleteFile (bcsymbolmapPath dwarfUUID) verbose

It attempts to delete the file that exists. In the case that the file does not exist, it should just ignore it and not print and error.

Rome version: 0.23.1.61
OS and version: macOS Catalina

[tmspzz]

Please see #178 (comment)

I understand this is annoying but I don't have plans to fix it.

I'm open to contributions fixing this tho ;)

[martianplatypus]

Hi @tmspzz, what would you like to see as a solution? Rename the error to a warning as proposed in #178 and #109 or what @christophercotton is suggesting here?

[christophercotton]

@martianplatypus in this case, I don't think it should be a warning. It is the normal operation that on a CI that the file doesn't exist since you are doing a new checkout. In this case it should just check to see if the file exists before trying to delete. I will try adding that check at some point, though I need to get setup to do Haskel.

[tmspzz]

@martianplatypus the fix is to check if the file exists and only delete it in that case