Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranger and xgboost don't respect R's seed #281

Open
jeremyrcoyle opened this issue Jun 23, 2020 · 0 comments
Open

ranger and xgboost don't respect R's seed #281

jeremyrcoyle opened this issue Jun 23, 2020 · 0 comments
Labels

Comments

@jeremyrcoyle
Copy link
Collaborator

Instead, each takes a separate seed argument. Currently, users can specify these manually as parameters:

lrnr_ranger <- make_learner(Lrnr_ranger, min.node.size = 30, num.trees=500, max.depth=2, seed=1234)
lrnr_xgboost <- make_learner(Lrnr_xgboost, minobspernode = 30, ntrees=500, max_depth=2, subsample=1, seed=1234)

However, we should manually generate and set seeds for these learners as a function of the current R seed to make reproducibility easier. Thanks to @yqzhong7 for reporting issues with reproducibility and these learners

@nhejazi nhejazi added the bug label Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants