Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify #6

Open
anselmdk opened this issue Mar 3, 2016 · 0 comments
Open

Simplify #6

anselmdk opened this issue Mar 3, 2016 · 0 comments

Comments

@anselmdk
Copy link
Member

anselmdk commented Mar 3, 2016

I've found this module useful for quite a few projects already, however it's unnecessary complicated.

Beyond simplifying the code (which I've taken a stab at in 385dfe4), I'd like the interface to dictate less methods.
Right now it dictates the following:

//Dictated by {@see UploadDirRulesInterface}:
function getCalcAssetsFolderDirectory()
{
    return 'apps';
}
function getMessageSaveFirst()
{
    return null;
}
function getMessageUploadDirectory()
{
    return null;
}
function getReadyForFolderCreation()
{
    return true;
}

I think we could get around with only dictating getCalcAssetsFolderDirectory, and leaving the rest as optional. Actually, getReadyForFolderCreation seems a little obsolete, as it can perfectly be handled by getCalcAssetsFolderDirectory returning something, or false.

Not sure if this would be a best practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant