Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failednotifs #55

Closed
pjebs opened this issue Jun 9, 2015 · 3 comments
Closed

Failednotifs #55

pjebs opened this issue Jun 9, 2015 · 3 comments

Comments

@pjebs
Copy link

pjebs commented Jun 9, 2015

When Failednotifs has objects, do I have to use the send command to attempt to resend?

@nathany
Copy link
Contributor

nathany commented Jun 11, 2015

timehop/apns automatically buffers the last 50 notifications and resends them if an error occurs (the notifications after the error)

@nathany nathany closed this as completed Jun 11, 2015
@pjebs
Copy link
Author

pjebs commented Jun 12, 2015

What if there were more than 50 notifications after the error occurred?
Are they lost forever?

@nathany
Copy link
Contributor

nathany commented Jun 12, 2015

At the moment, yes, it's a circular buffer so the most recent are kept. The code does continuously read off the socket for errors from Apple, so it should be more responsive than waiting for a write to fail.

Also, if the Go process you are running crashes, that buffer disappears.

See #47 for some real world issues as of late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants