From 81893f7ed7307b3464847d3c9e7de90ea8c02766 Mon Sep 17 00:00:00 2001
From: Geoff Harcourt <geoff.harcourt@gmail.com>
Date: Sun, 1 Aug 2021 15:08:45 -0400
Subject: [PATCH] Drop `redis-cli` command

Heroku now offers their own `redis:cli` subcommand, making this
unnecessary.

This change will require a major release as we're removing the feature
entirely.
---
 README.md                       |  6 ------
 lib/parity/environment.rb       | 10 ----------
 spec/parity/environment_spec.rb | 28 ----------------------------
 3 files changed, 44 deletions(-)

diff --git a/README.md b/README.md
index 97e16d1..fd49f94 100644
--- a/README.md
+++ b/README.md
@@ -77,12 +77,6 @@ Tail a log:
     staging tail
     pr_app 1234 tail
 
-Use [redis-cli][2] with your `REDIS_URL` add-on:
-
-    production redis-cli
-    staging redis-cli
-    pr_app 1234 redis-cli
-
 The scripts also pass through, so you can do anything with them that you can do
 with `heroku ______ --remote staging` or `heroku ______ --remote production`:
 
diff --git a/lib/parity/environment.rb b/lib/parity/environment.rb
index 5b090a4..f293ff4 100644
--- a/lib/parity/environment.rb
+++ b/lib/parity/environment.rb
@@ -126,16 +126,6 @@ def tail
       )
     end
 
-    def redis_cli
-      Kernel.system("redis-cli", "-u", raw_redis_url)
-    end
-
-    def raw_redis_url
-      @redis_to_go_url ||= Open3.
-        capture3(command_for_remote("config:get REDIS_URL"))[0].
-        strip
-    end
-
     def heroku_app_name
       HerokuAppName.new(environment).to_s
     end
diff --git a/spec/parity/environment_spec.rb b/spec/parity/environment_spec.rb
index 34bc6ec..89bdc1f 100644
--- a/spec/parity/environment_spec.rb
+++ b/spec/parity/environment_spec.rb
@@ -224,22 +224,6 @@
     expect(Kernel).to have_received(:exec).with(*open)
   end
 
-  it "opens a Redis session connected to the environment's Redis service" do
-    allow(Open3).to receive(:capture3).and_return(open3_redis_url_fetch_result)
-
-    Parity::Environment.new("production", ["redis_cli"]).run
-
-    expect(Kernel).to have_received(:system).with(
-      "redis-cli",
-      "-u",
-      open3_redis_url_fetch_result[0].strip,
-    )
-    expect(Open3).
-      to have_received(:capture3).
-      with(fetch_redis_url("REDIS_URL")).
-      once
-  end
-
   it "returns true if deploy was successful without migrations" do
     result = Parity::Environment.new("production", ["deploy"]).run
 
@@ -327,18 +311,6 @@ def open
     ["heroku", "open", "--remote", "production"]
   end
 
-  def fetch_redis_url(env_variable)
-    "heroku config:get #{env_variable} --remote production"
-  end
-
-  def open3_redis_url_fetch_result
-    [
-      "redis://redistogo:abcd1234efgh5678@landshark.redistogo.com:90210/\n",
-      "",
-      ""
-    ]
-  end
-
   def psql_count
     [
       "heroku", "pg:psql",