Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link issues with empty contexts and non-empty identities #55

Open
magneticflux- opened this issue Sep 19, 2021 · 0 comments
Open

Link issues with empty contexts and non-empty identities #55

magneticflux- opened this issue Sep 19, 2021 · 0 comments

Comments

@magneticflux-
Copy link

A user of a mod I develop reported an issue with CrossTalk that did not manifest in Mumble using the Link plugin. I looked around and did some debugging and found what might be the cause of the issue.

Here's the issue and full debugging steps: https://github.com/magneticflux-/fabric-mumblelink-mod/issues/79#issuecomment-922429042

And here's just the summary:

When sending plugin info, the plugin writes [Ct_None] to a QTextStream if the context is empty (here). Later, when that QTextStream is interpreted (here), the value is taken verbatim, without checking for [Ct_None].
I believe this means that when a client receives info from other clients it sees their contexts incorrectly as "[Ct_None]" but sees its own context correctly as ""?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant