Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] PTL doesn't have an open source toolchain, "xtensa-build-zephyr.py ptl" fails by default #9262

Open
andyross opened this issue Jun 26, 2024 · 5 comments
Open

[BUG] PTL doesn't have an open source toolchain, "xtensa-build-zephyr.py ptl" fails by default #9262

andyross opened this issue Jun 26, 2024 · 5 comments
Labels
bug Something isn't working as expected
Milestone
v2.12

Comments

@andyross
Copy link
Contributor

The PTL platform merged without a toolchain added to the Zephyr SDK for the ace30_ptl SOC, or any other way to create one. This means that builds from a bare tree checkout are always going to fail without access to the Cadence SDK for the device. Also new work that might impact the platform (c.f #9261) can't be validated by the submitter.

At the very least, if there's resistance to adding another toolchain to the already huge Zephyr SDK[1] an overlay file should be added to the SOF xtensa-overlays project ( https://github.com/thesofproject/xtensa-overlay ) so that users can build their own.

[1] There are, to be sure, a lot of Xtensa variants in there now.
@andyross andyross added the bug Something isn't working as expected label Jun 26, 2024
@andyross
Copy link
Contributor Author

FWIW: another side band option would be to get partners copies of the relevant Cadence SDK integration files so they could do the work themselves.

marc-hb added a commit to marc-hb/sof that referenced this issue Jun 27, 2024
@marc-hb
.github: add a test for xtensa-build-zephyr.py --all
6a6a457 
Add a test to avoid --all breakages like the one in commit
05bfc36 ("ptl: Add initial PTL configuration"), reported in thesofproject#9262

See also previous commit.

Signed-off-by: Marc Herbert <[email protected]>
marc-hb added a commit to marc-hb/sof that referenced this issue Jun 27, 2024
@marc-hb
xtensa-build-zephyr.py: move PTL out of "all" and into "extra".
8181e2b 
As reported in thesofproject#9262, this fixes the --all option.

Fixes commit 05bfc36 ("ptl: Add initial PTL configuration")

Signed-off-by: Marc Herbert <[email protected]>
marc-hb added a commit to marc-hb/sof that referenced this issue Jun 27, 2024
@marc-hb
.github: add a test for xtensa-build-zephyr.py --all
0b84ae1 
Add a test to avoid --all breakages like the one in commit
05bfc36 ("ptl: Add initial PTL configuration"), reported in thesofproject#9262

See also previous commit.

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb marc-hb mentioned this issue Jun 27, 2024
Merged
@abonislawski
Copy link
Member

At the very least, if there's resistance to adding another toolchain to the already huge Zephyr SDK[1]

Do you have this in mind?
zephyrproject-rtos/sdk-ng#767

@lgirdwood not sure about the current policy, we should have it also in xtensa-overlay repo or sdk-ng is enough?

kv2019i pushed a commit that referenced this issue Jul 2, 2024
@marc-hb @kv2019i
xtensa-build-zephyr.py: move PTL out of "all" and into "extra".
d9e6b7b 
As reported in #9262, this fixes the --all option.

Fixes commit 05bfc36 ("ptl: Add initial PTL configuration")

Signed-off-by: Marc Herbert <[email protected]>
kv2019i pushed a commit that referenced this issue Jul 2, 2024
@marc-hb @kv2019i
.github: add a test for xtensa-build-zephyr.py --all
2aaee2e 
Add a test to avoid --all breakages like the one in commit
05bfc36 ("ptl: Add initial PTL configuration"), reported in #9262

See also previous commit.

Signed-off-by: Marc Herbert <[email protected]>
@lgirdwood
Copy link
Member

At the very least, if there's resistance to adding another toolchain to the already huge Zephyr SDK[1]

Do you have this in mind? zephyrproject-rtos/sdk-ng#767

@lgirdwood not sure about the current policy, we should have it also in xtensa-overlay repo or sdk-ng is enough?

I think CI needs it on SOF side i.e. for GCC front end static analysis for PR testing but IIRC it should all come via Zephyr SDK now.

@lgirdwood lgirdwood added this to the v2.11 milestone Jul 5, 2024
eddy1021 pushed a commit to eddy1021/sof that referenced this issue Jul 15, 2024
@marc-hb
xtensa-build-zephyr.py: move PTL out of "all" and into "extra".
9190613 
As reported in thesofproject#9262, this fixes the --all option.

Fixes commit 05bfc36 ("ptl: Add initial PTL configuration")

Signed-off-by: Marc Herbert <[email protected]>
eddy1021 pushed a commit to eddy1021/sof that referenced this issue Jul 15, 2024
@marc-hb
.github: add a test for xtensa-build-zephyr.py --all
5c93355 
Add a test to avoid --all breakages like the one in commit
05bfc36 ("ptl: Add initial PTL configuration"), reported in thesofproject#9262

See also previous commit.

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb
Copy link
Collaborator

marc-hb commented Aug 14, 2024 •
edited
Loading

Current GitHub workflows in sof/.github/ use a Zephyr docker image exclusively - because it provides the Zephyr SDK.
https://github.com/zephyrproject-rtos/docker-image

@kv2019i kv2019i modified the milestones: v2.11, v2.12 Sep 6, 2024
@kv2019i
Copy link
Collaborator

kv2019i commented Sep 6, 2024

zephyrproject-rtos/sdk-ng#767 is now merged, so support exists in Zephyr SDK.

No activity on the xtensa-overlay and "ptl" is still marked in extras, so I'll keep this open until we have more clear concensus (either the Zephyr SDK is sufficient for Zephyr native SOF platform and/or xtensa-overlay is updated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected
Projects
None yet
Milestone
v2.12
Development

No branches or pull requests
5 participants
@andyross @lgirdwood @abonislawski @kv2019i @marc-hb