Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Type Inconsistency #1056

Open
Sephster opened this issue Oct 2, 2019 · 0 comments
Open

Return Type Inconsistency #1056

Sephster opened this issue Oct 2, 2019 · 0 comments
Labels
Future Version

Comments

@Sephster
Copy link
Member

Sephster commented Oct 2, 2019

Most repos return string for their getIdentifier() function. However, the user repo returns mixed. This causes confusion as implementers might think that you can return mixed for a client repository but this is not true.

We either need to move the getIdentifier calls into their own respective repos or force the user interface getIdentifier call to return a string in version 9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Future Version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sephster