Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getResourceOwner parameter type #956

Open
nrob81 opened this issue Jun 16, 2022 · 1 comment
Open

getResourceOwner parameter type #956

nrob81 opened this issue Jun 16, 2022 · 1 comment

Comments

@nrob81
Copy link

nrob81 commented Jun 16, 2022

Hello,

Doesn't would be better to set the type of the $token parameter here to AccessTokenInterface instead of AccessToken?

public function getResourceOwner(AccessToken $token)

what do you think?
Thanks

@esolitos
Copy link

esolitos commented Jun 16, 2022

While you are absolutely correct: it would be better to expect Interfaces and not specific implementations, it is to consider that this small change would require a new major release because it would break bacward compatibility, as it happened in the past (ref #753 and #752 for example).

And I highly doubt a new major release will be created only for this alone.

Edit: as a matter of fact this is already being tracked in #897 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants