Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glide + CDN services #233

Closed
darkponyhq opened this issue May 28, 2018 · 2 comments
Closed

Glide + CDN services #233

darkponyhq opened this issue May 28, 2018 · 2 comments

Comments

@darkponyhq
Copy link

Hi there,

Glide is an amazing library. The only major drawback we came across during the last two years we are using it, is the "by design" problem with dynamic cropping.

Cropping (and other functionality) is being pass as a query string on the url, e.g.

yourdomain.com/image.jpg?w=300&h=300&fit=crop

The problem with all the CDN services I came across is that the standard pull/fetch service ignores the query string, so if the images are served via CDN all the custom cropping is gone!

It was discussed in this post

#170

the posibility of pushing this query data within the URL, is this implemented?

e.g.

http://example.com/img/kayaks.jpg/w-800-h-500-fit-crop-s-5ac7f6163057bf1931fd5b513f797644939ece7724ee3846a27e9915f3ea5eda.jpg

This will solve the problem since CDN services will fetch the right data and there will be no query info to discard. It is not as SEO friendly as it could, be the CDN issue is major (at least for us).

Thanks again for this amazing library.

@calumbrodie
Copy link

Every CDN I've ever used allows you to cache based on query strings so I'm not 100% what the issue is here?

https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/QueryStringParameters.html

Cloudflare has this feature within page rules.

Is it that it's just less hassle/setup to use a filename/path than using query strings?

@tgalopin
Copy link
Member

Planned for the next major, closing as duplicate of #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants