Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SftpAdapter does not catch UnableToConnectToSftpHost #1305

Closed
dakur opened this issue May 4, 2021 · 4 comments
Closed

SftpAdapter does not catch UnableToConnectToSftpHost #1305

dakur opened this issue May 4, 2021 · 4 comments

Comments

@dakur
Copy link

dakur commented May 4, 2021 •
edited
Loading

And underlying layer does not annotate it: thephpleague/flysystem-sftp#124
@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 8, 2021
@dakur
Copy link
Author

dakur commented Jul 8, 2021 •
edited
Loading

not resolved yet

@stale stale bot removed the stale label Jul 8, 2021
@stof
Copy link
Contributor

stof commented Jan 12, 2022

There is no reason to catch it, as UnableToConnectToSftpHost implements FilesystemException

@frankdejonge
Copy link
Member

This expected, as @stof mentioned, it's covered by the contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stof @frankdejonge @dakur