Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpseclib3 for the sftp adapter #1261

Closed
stof opened this issue Jan 21, 2021 · 9 comments
Closed

phpseclib3 for the sftp adapter #1261

stof opened this issue Jan 21, 2021 · 9 comments
Labels
keep open prevent issue from going stale

Comments

@stof
Copy link
Contributor

stof commented Jan 21, 2021

Question

Is there any plan to update league/flysystem-sftp to use phpseclib3 instead of phpseclib 2, so that it supports newer crypto algorithms ? See also thephpleague/flysystem-sftp#111 and thephpleague/flysystem-sftp#110 but I figured out that the 2.x branch of league/flysystem-sftp is actually a subtree split from here so I'm bringing it here.

Also, the namespace for the class in v2 includes PhpseclibV2 so I don't see what the plan could be when migrating to v3

@IonBazan
Copy link

@stof We could use https://github.com/phpseclib/phpseclib2_compat to maintain compatibility with both.

@Nyholm
Copy link
Member

Nyholm commented Feb 1, 2021

There is a PR starting to add a PhpseclibV3 for Flysystem 2

#1257

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 2, 2021
@stof
Copy link
Contributor Author

stof commented Jun 2, 2021

this issue is still relevant, as the PR is still in progress

@stale stale bot removed the stale label Jun 2, 2021
@lupo112
Copy link

lupo112 commented Jun 11, 2021

any progress? i have the same problem with server host key

@frankdejonge
Copy link
Member

I've merged the PR for this. Interested people can try the v3 variant here: https://packagist.org/packages/league/flysystem-sftp-v3

@frankdejonge
Copy link
Member

Any feedback on this before I tag an stable version?

@hbraehne
Copy link

I just upgraded a rather large application from flysystem-sftp to flysystem-sftp-v3 to gain support for DSA keys. In our dev and staging environment everything seems to work as expected. Are there any plans to release a stable version soon?

@VladimirCyberDev
Copy link

I tried v3 today, haven't noticed any issue, seem to be working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep open prevent issue from going stale
Projects
None yet
Development

No branches or pull requests

7 participants