diff --git a/docs/9.0/reader/statement.md b/docs/9.0/reader/statement.md index 984bd5be..515a21be 100644 --- a/docs/9.0/reader/statement.md +++ b/docs/9.0/reader/statement.md @@ -138,8 +138,8 @@ $constraints = Statement::create() ->select('Integer', 'Text', 'Date and Time') ->where(fn (array $record): bool => (float) $record['Float'] < 1.3) ->orderBy(fn (array $r1, array $r2): int => (int) $r2['Integer'] <=> (int) $r1['Integer']) - ->limit(5) - ->offset(2); + ->offset(2) + ->limit(5); $document = <<setHeaderOffset(0); $records = $constraints->process($csv); -//returns a ResultSet containing records which validates all the constraints. +//returns a ResultSet containing records which validate all the constraints. ``` -Since the `Statement` instance is created independent of the CSV document you can re-use it on different CSV -document or `TabularDataReader` instances if needed. +Since a `Statement` instance is independent of the CSV document you can re-use it on different CSV +documents or `TabularDataReader` instances if needed. ## FragmentFinder diff --git a/src/AbstractCsvTest.php b/src/AbstractCsvTest.php index 97e3aafb..5c14fcb4 100644 --- a/src/AbstractCsvTest.php +++ b/src/AbstractCsvTest.php @@ -29,7 +29,6 @@ use function xdebug_get_headers; use const PHP_EOL; -use const PHP_VERSION_ID; #[Group('csv')] final class AbstractCsvTest extends TestCase @@ -415,10 +414,6 @@ public function testBOMStripping(): void public function testOutputStripBOM(): void { - if (PHP_VERSION_ID >= 80300) { - self::markTestSkipped('Issue with PHPUnit in PHP8.3'); - } - $raw_csv = ByteSequence::BOM_UTF8."john,doe,john.doe@example.com\njane,doe,jane.doe@example.com\n"; $csv = Reader::createFromString($raw_csv); $csv->setOutputBOM(ByteSequence::BOM_UTF16_BE); @@ -434,10 +429,6 @@ public function testOutputStripBOM(): void public function testOutputDoesNotStripBOM(): void { - if (PHP_VERSION_ID >= 80300) { - self::markTestSkipped('Issue with PHPUnit in PHP8.3'); - } - $raw_csv = ByteSequence::BOM_UTF8."john,doe,john.doe@example.com\njane,doe,jane.doe@example.com\n"; $csv = Reader::createFromString($raw_csv); $csv->setOutputBOM(ByteSequence::BOM_UTF16_BE);