Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative miner for non-admin Windows users #48

Open
matthewboman opened this issue Dec 22, 2017 · 2 comments
Open

Alternative miner for non-admin Windows users #48

matthewboman opened this issue Dec 22, 2017 · 2 comments

Comments

@matthewboman
Copy link

Windows users with non-admin privileges get the following error:

image001

when miner.js tried to spawn the process because the user doesn't have permission to run the executable.

I think a good solution would be to listen for this error, and if it happens, running a different miner. One option would be to use an external worker like coinhive, which would take a percentage but still be better than nothing. Another option would be to write a worker that could run not as an executable.

What do people think?

@Artoria2e5
Copy link
Contributor

Artoria2e5 commented Dec 25, 2017

The miner itself runs fine (with slightly lower performance due to some huge page things) with a regular user. I don't think it's xmrig's problem here.

If you look for ENOENT it seems to mean "no such entry" -- the file is not there, probably removed by some antivirus as Trojan/Miner. In that case it makes sense to fall back to stuff like Coinhive, but if the antivirus wants to kill all miners it will end up looking for coinhive & friends too. (And with Coinhive's performance, we can't keep the "you give more than your electric bill" bit in the FAQ.)

@matthewboman
Copy link
Author

That's strange it's throwing ENOENT then, because the file still exists in the directory. I'll see what options for miners there are where the performance is actually worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants