Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't turn on dark theme based on time #38

Open
kidonng opened this issue Aug 29, 2021 · 0 comments
Open

Don't turn on dark theme based on time #38

kidonng opened this issue Aug 29, 2021 · 0 comments

Comments

@kidonng
Copy link

kidonng commented Aug 29, 2021

I think we are at a stage where we can assume prefers-color-scheme and system wide dark mode are widely supported: https://caniuse.com/prefers-color-scheme

Therefore the following lines:

gitstalk/src/App.vue

Lines 72 to 73 in 2ff5fd5

today.getHours() >= 22 ||
(today.getHours() >= 0 && today.getHours() <= 5) ||

Which turns on dark them when it is 22:00-05:00 seems unnecessary. As for myself, I frequently encounter a situation that Gitstalk turns dark while rest of my system doesn't, which is pretty confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant