Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

[extensions] extension commands no longer work #60

Open
JanKoehnlein opened this issue Aug 16, 2018 · 0 comments
Open

[extensions] extension commands no longer work #60

JanKoehnlein opened this issue Aug 16, 2018 · 0 comments

Comments

@JanKoehnlein
Copy link
Member

Extension commands (commands defined in the config fiels,implemented in a jar in the WS and dynamically added by the server) no longer get an entry in the menu.

The reason is that Theia/Monaco LC switched to a global command registry, and our hooks that atuomatically add labels (prerequisite to be added in the quick command list) and menu entries are no longer called.

We may have to add a hook in Theia that allows extensions to hook into the registration of server-side commands https://github.com/Microsoft/vscode-languageserver-node/blob/7850be5cce4ed39485150969de14947d08c47375/client/src/client.ts#L2200
That is unfortunately a bit complicated, as the ExecuteCommandFeature is not exported by vscode. @akosyakov filed a PR for that microsoft/vscode-languageserver-node#379

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant