From a928e428174a6801890fdb37f0b19c1dfda332dc Mon Sep 17 00:00:00 2001
From: Leos Stejskal <lstejska@redhat.com>
Date: Tue, 19 Sep 2023 14:51:15 +0200
Subject: [PATCH] Rubocop

---
 .github/workflows/ruby.yml |   8 +
 .rubocop.yml               | 154 +--------
 .rubocop_todo.yml          | 638 +++++++++++++++++++++++++++++++------
 Gemfile                    |   1 +
 4 files changed, 556 insertions(+), 245 deletions(-)

diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml
index 81a73930d..0fc73e846 100644
--- a/.github/workflows/ruby.yml
+++ b/.github/workflows/ruby.yml
@@ -6,9 +6,17 @@ env:
   RAILS_ENV: test
   DATABASE_URL: postgresql://postgres:@localhost/test
   DATABASE_CLEANER_ALLOW_REMOTE_DATABASE_URL: true
+concurrency:
+  group: ${{ github.head_ref }}
+  cancel-in-progress: true
 jobs:
+  rubocop:
+    uses: theforeman/actions/.github/workflows/rubocop.yml@v0
+    with:
+      command: bundle exec rubocop --parallel --format github
   test_ruby:
     runs-on: ubuntu-latest
+    needs: rubocop
     services:
       postgres:
         image: postgres:12.1
diff --git a/.rubocop.yml b/.rubocop.yml
index 5dfd1c5da..559969fde 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,151 +1,5 @@
-require:
-  - rubocop-performance
-  - rubocop-rails
-  - rubocop-minitest
+inherit_from: .rubocop_todo.yml
 
-inherit_from:
-  - .rubocop_todo.yml
-
-AllCops:
-  TargetRubyVersion: 2.5
-  TargetRailsVersion: 5.2
-  Include:
-    - 'app/views/api/**/*.rabl'
-    - 'app/**/*.rb'
-    - 'lib/**/*.rb'
-    - 'test/**/*.rb'
-    - 'test/**/*.rb'
-  Exclude:
-    - 'db/schema.rb'
-    - 'node_modules/**/*'
-    - 'vendor/**/*'
-    - 'release-gem'
-    - 'extra/discover-host'
-
-Bundler/OrderedGems:
-  Enabled: false
-
-Layout/ArgumentAlignment:
-  EnforcedStyle: with_fixed_indentation
-  IndentationWidth: 2
-
-Layout/DotPosition:
-  Enabled: false
-
-Layout/FirstArgumentIndentation:
-  EnforcedStyle: consistent
-
-Layout/HashAlignment:
-  Enabled: false
-
-Layout/LineLength:
-  Enabled: false
-
-Layout/ParameterAlignment:
-  Enabled: false
-
-Metrics:
-  Enabled: false
-
-Performance/Casecmp:
-  Enabled: false
-
-Performance/RedundantMatch:
-  Enabled: true
-
-Performance/RedundantMerge:
-  Enabled: true
-
-Performance/RegexpMatch:
-  Enabled: false
-
-Rails:
-  Enabled: true
-
-Rails/Blank:
-  UnlessPresent: false
-
-# Won't work with sqlite
-Rails/BulkChangeTable:
-  Enabled: false
-
-Rails/RefuteMethods:
-  Enabled: false
-
-Style/Alias:
-  EnforcedStyle: prefer_alias_method
-
-Style/AndOr:
-  EnforcedStyle: conditionals
-
-# Don't prefer is_a? over kind_of?
-Style/ClassCheck:
-  Enabled: false
-
-# Don't enforce certain methods, e.g. detect over find
-Style/CollectionMethods:
-  Enabled: false
-
-Style/ConditionalAssignment:
-  Enabled: false
-
-# Don't enforce documentation
-Style/Documentation:
-  Enabled: false
-
-Style/EmptyMethod:
-  EnforcedStyle: expanded
-
-# Don't enforce frozen string literals
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-# Support both, Ruby 1.9 hashmap and hash-rocket syntax
-Style/HashSyntax:
-  Enabled: false
-
-Style/IfUnlessModifier:
-  Enabled: false
-
-Style/InverseMethods:
-  Enabled: false
-
-# disabled until we can configure "+" as concat sign
-Style/LineEndConcatenation:
-  Enabled: false
-
-Style/MultipleComparison:
-  Enabled: false
-
-Style/NumericPredicate:
-  Enabled: false
-
-Style/ParallelAssignment:
-  Enabled: false
-
-Style/ParenthesesAroundCondition:
-  Enabled: false
-
-Style/PreferredHashMethods:
-  Enabled: false
-
-# Both double and single quotes are OK
-Style/StringLiterals:
-  Enabled: false
-
-Style/SymbolArray:
-  EnforcedStyle: brackets
-  MinSize: 1
-
-Style/TernaryParentheses:
-  EnforcedStyle: require_parentheses_when_complex
-
-Style/TrailingCommaInArrayLiteral:
-  EnforcedStyleForMultiline: comma
-
-Style/TrailingCommaInHashLiteral:
-  EnforcedStyleForMultiline: comma
-
-#Allow both ['a', 'b'], %w[a b] and %w(a b) style arrays
-Style/WordArray:
-  Enabled: false
+inherit_gem:
+  theforeman-rubocop:
+    - default.yml
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 390c240d4..0be024707 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,12 +1,19 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-04-17 15:41:13 +0200 using RuboCop version 0.80.1.
+# on 2023-10-04 07:15:50 UTC using RuboCop version 1.23.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 26
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'foreman_discovery.gemspec'
+
+# Offense count: 39
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: with_first_argument, with_fixed_indentation
@@ -14,17 +21,23 @@ Layout/ArgumentAlignment:
   Exclude:
     - 'app/controllers/api/v2/discovered_hosts_controller.rb'
     - 'app/helpers/discovered_hosts_helper.rb'
-    - 'test/functional/api/v2/fact_value_extensions_test.rb'
-    - 'test/functional/discovered_hosts_controller_test.rb'
+    - 'app/services/foreman_discovery/lldp_neighbors.rb'
+    - 'test/factories/discovery_host_related.rb'
     - 'test/integration/discovered_hosts_test.rb'
     - 'test/test_helper_discovery.rb'
     - 'test/unit/discovered_extensions_test.rb'
     - 'test/unit/discovered_mailer_test.rb'
-    - 'test/unit/discovery_attribute_set_test.rb'
-    - 'test/unit/fact_parser_test.rb'
     - 'test/unit/host_discovered_test.rb'
 
-# Offense count: 9
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith.
+# SupportedStylesAlignWith: either, start_of_block, start_of_line
+Layout/BlockAlignment:
+  Exclude:
+    - 'lib/foreman_discovery/engine.rb'
+
+# Offense count: 11
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
 # SupportedStyles: case, end
@@ -42,28 +55,29 @@ Layout/ClosingParenthesisIndentation:
     - 'app/services/foreman_discovery/lldp_neighbors.rb'
     - 'test/unit/host_discovered_test.rb'
 
-# Offense count: 21
+# Offense count: 3
 # Cop supports --auto-correct.
-Layout/EmptyLineAfterGuardClause:
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: leading, trailing
+Layout/DotPosition:
   Exclude:
-    - 'app/controllers/concerns/foreman/controller/discovered_extensions.rb'
-    - 'app/controllers/discovered_hosts_controller.rb'
-    - 'app/controllers/foreman_discovery/concerns/hosts_controller_extensions.rb'
-    - 'app/helpers/discovered_hosts_helper.rb'
-    - 'app/helpers/discovery_rules_helper.rb'
-    - 'app/models/discovery_rule.rb'
     - 'app/models/host/discovered.rb'
-    - 'app/models/host/managed_extensions.rb'
-    - 'app/models/nic/managed_extensions.rb'
-    - 'app/services/foreman_discovery/import_hooks/lldp_neighbor.rb'
-    - 'app/services/foreman_discovery/lldp_neighbors.rb'
-    - 'app/services/foreman_discovery/node_api/node_resource.rb'
+    - 'db/migrate/20160925213030_change_discovery_widget_names.rb'
 
-# Offense count: 1
+# Offense count: 3
 # Cop supports --auto-correct.
 Layout/EmptyLineAfterMagicComment:
   Exclude:
+    - 'app/services/foreman_discovery/ui_notifications/failed_discovery.rb'
     - 'app/services/foreman_discovery/ui_notifications/new_host.rb'
+    - 'db/seeds.d/90_add_permissions_from_default_roles.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, AllowAdjacentOneLineDefs, NumberOfEmptyLines.
+Layout/EmptyLineBetweenDefs:
+  Exclude:
+    - 'test/unit/discovered_extensions_test.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
@@ -71,12 +85,13 @@ Layout/EmptyLines:
   Exclude:
     - 'test/functional/api/v2/fact_value_extensions_test.rb'
 
-# Offense count: 1
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, no_empty_lines
 Layout/EmptyLinesAroundBlockBody:
   Exclude:
+    - 'config/routes.rb'
     - 'lib/foreman_discovery/engine.rb'
 
 # Offense count: 5
@@ -86,8 +101,8 @@ Layout/EmptyLinesAroundBlockBody:
 Layout/EmptyLinesAroundClassBody:
   Exclude:
     - 'app/services/foreman_discovery/node_api/power_service.rb'
+    - 'db/migrate/20180412124505_add_priority_score_to_discovery_rules.rb'
     - 'lib/foreman_discovery/engine.rb'
-    - 'test/functional/api/v2/discovered_hosts_controller_test.rb'
     - 'test/functional/discovery_rules_controller_test.rb'
     - 'test/unit/fact_parser_test.rb'
 
@@ -99,13 +114,15 @@ Layout/EmptyLinesAroundModuleBody:
   Exclude:
     - 'app/controllers/concerns/foreman/controller/discovered_extensions.rb'
 
-# Offense count: 6
+# Offense count: 9
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
 Layout/ExtraSpacing:
   Exclude:
     - 'app/controllers/concerns/foreman/controller/discovered_extensions.rb'
+    - 'app/controllers/discovered_hosts_controller.rb'
     - 'app/helpers/discovered_hosts_helper.rb'
+    - 'test/functional/api/v2/discovered_hosts_controller_test.rb'
     - 'test/unit/ui_notifications/destroy_host_test.rb'
     - 'test/unit/ui_notifications/new_host_test.rb'
 
@@ -126,7 +143,7 @@ Layout/FirstArgumentIndentation:
 Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
-# Offense count: 24
+# Offense count: 20
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: special_inside_parentheses, consistent, align_braces
@@ -134,26 +151,63 @@ Layout/FirstHashElementIndentation:
   Exclude:
     - 'app/controllers/api/v2/discovered_hosts_controller.rb'
     - 'app/helpers/discovered_hosts_helper.rb'
+    - 'db/seeds.d/70_discovery_mail_notification.rb'
+    - 'test/functional/api/v2/discovered_hosts_controller_test.rb'
+    - 'test/functional/api/v2/fact_value_extensions_test.rb'
+    - 'test/functional/discovered_hosts_controller_test.rb'
+    - 'test/unit/host_discovered_test.rb'
+
+# Offense count: 57
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
+  Exclude:
+    - 'app/services/foreman_discovery/lldp_neighbors.rb'
+    - 'app/services/foreman_discovery/node_api/node_resource.rb'
+    - 'lib/foreman_discovery/engine.rb'
     - 'test/functional/api/v2/discovered_hosts_controller_test.rb'
     - 'test/functional/api/v2/fact_value_extensions_test.rb'
     - 'test/functional/discovered_hosts_controller_test.rb'
+    - 'test/test_helper_discovery.rb'
     - 'test/unit/host_discovered_test.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: normal, indented_internal_methods
+Layout/IndentationConsistency:
+  Exclude:
+    - 'lib/foreman_discovery/engine.rb'
+
+# Offense count: 10
+# Cop supports --auto-correct.
 # Configuration parameters: Width, IgnoredPatterns.
 Layout/IndentationWidth:
   Exclude:
     - 'app/models/discovery_rule.rb'
-    - 'app/services/foreman_discovery/host_converter.rb'
+    - 'app/services/foreman_discovery/host_fact_importer.rb'
+    - 'db/migrate/20171222120314_add_constraints_on_discovery_rules_hostgroups.rb'
+    - 'db/migrate/20180412124505_add_priority_score_to_discovery_rules.rb'
+    - 'lib/foreman_discovery/engine.rb'
 
-# Offense count: 4
+# Offense count: 2
+# Cop supports --auto-correct.
+Layout/InitialIndentation:
+  Exclude:
+    - 'db/migrate/20171222120314_add_constraints_on_discovery_rules_hostgroups.rb'
+    - 'db/migrate/20180412124505_add_priority_score_to_discovery_rules.rb'
+
+# Offense count: 5
 # Cop supports --auto-correct.
 # Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment.
 Layout/LeadingCommentSpace:
   Exclude:
     - 'app/controllers/discovery_rules_controller.rb'
     - 'lib/foreman_discovery/engine.rb'
+    - 'test/migrations/20221102075151_migrate_discovery_hostname_and_fact_column_to_array_test.rb'
     - 'test/unit/host_discovered_test.rb'
 
 # Offense count: 7
@@ -173,7 +227,7 @@ Layout/MultilineHashBraceLayout:
 Layout/MultilineMethodCallBraceLayout:
   Exclude:
     - 'app/helpers/discovered_hosts_helper.rb'
-    - 'test/test_helper_discovery.rb'
+    - 'app/models/discovery_rule.rb'
     - 'test/unit/discovered_mailer_test.rb'
     - 'test/unit/host_discovered_test.rb'
 
@@ -186,20 +240,22 @@ Layout/MultilineMethodCallIndentation:
     - 'app/models/host/discovered.rb'
     - 'app/services/foreman_discovery/lldp_neighbors.rb'
 
-# Offense count: 1
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: aligned, indented
 Layout/MultilineOperationIndentation:
   Exclude:
     - 'app/helpers/discovered_hosts_helper.rb'
+    - 'foreman_discovery.gemspec'
 
-# Offense count: 13
+# Offense count: 19
 # Cop supports --auto-correct.
 Layout/SpaceAfterComma:
   Exclude:
     - 'app/helpers/discovered_hosts_helper.rb'
     - 'app/models/host/discovered.rb'
+    - 'lib/discovery.rake'
     - 'test/unit/host_discovered_test.rb'
 
 # Offense count: 1
@@ -208,7 +264,7 @@ Layout/SpaceAfterNot:
   Exclude:
     - 'app/lib/facter_utils.rb'
 
-# Offense count: 10
+# Offense count: 11
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
 # SupportedStylesForExponentOperator: space, no_space
@@ -220,7 +276,7 @@ Layout/SpaceAroundOperators:
     - 'app/helpers/discovered_hosts_helper.rb'
     - 'lib/foreman_discovery/engine.rb'
 
-# Offense count: 7
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space
@@ -228,6 +284,8 @@ Layout/SpaceAroundOperators:
 Layout/SpaceBeforeBlockBraces:
   Exclude:
     - 'app/models/host/discovered.rb'
+    - 'extra/discover-host'
+    - 'lib/foreman_discovery/engine.rb'
     - 'test/test_helper_discovery.rb'
 
 # Offense count: 3
@@ -236,15 +294,25 @@ Layout/SpaceBeforeComma:
   Exclude:
     - 'app/helpers/discovered_hosts_helper.rb'
 
-# Offense count: 2
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment.
 Layout/SpaceBeforeFirstArg:
   Exclude:
+    - 'test/functional/api/v2/discovered_hosts_controller_test.rb'
     - 'test/unit/ui_notifications/destroy_host_test.rb'
     - 'test/unit/ui_notifications/new_host_test.rb'
 
-# Offense count: 32
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBrackets: space, no_space
+Layout/SpaceInsideArrayLiteralBrackets:
+  Exclude:
+    - 'lib/foreman_discovery/engine.rb'
+
+# Offense count: 16
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
 # SupportedStyles: space, no_space
@@ -254,10 +322,12 @@ Layout/SpaceInsideBlockBraces:
     - 'app/controllers/discovered_hosts_controller.rb'
     - 'app/models/host/discovered.rb'
     - 'app/services/foreman_discovery/lldp_neighbors.rb'
+    - 'extra/discover-host'
+    - 'lib/foreman_discovery/engine.rb'
     - 'test/functional/api/v2/discovery_rules_controller_test.rb'
     - 'test/test_helper_discovery.rb'
 
-# Offense count: 189
+# Offense count: 200
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space, compact
@@ -265,55 +335,101 @@ Layout/SpaceInsideBlockBraces:
 Layout/SpaceInsideHashLiteralBraces:
   Enabled: false
 
-# Offense count: 4
+# Offense count: 5
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: space, no_space
+# SupportedStyles: space, compact, no_space
 Layout/SpaceInsideParens:
   Exclude:
     - 'app/controllers/discovered_hosts_controller.rb'
     - 'app/helpers/discovered_hosts_helper.rb'
+    - 'test/unit/discovery_rule_test.rb'
 
 # Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: final_newline, final_blank_line
+Layout/TrailingEmptyLines:
+  Exclude:
+    - 'app/services/foreman_discovery/fact_to_category_resolver.rb'
+    - 'db/migrate/20141126165451_add_discovery_id_to_subnet.rb'
+    - 'locale/action_names.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: AllowInHeredoc.
+Layout/TrailingWhitespace:
+  Exclude:
+    - 'app/services/foreman_discovery/host_converter.rb'
+    - 'db/migrate/20161006094714_add_constraints_on_subnets_smart_proxies.rb'
+    - 'test/unit/discovered_extensions_test.rb'
+
+# Offense count: 5
+# Configuration parameters: IgnoredMethods.
 Lint/AmbiguousBlockAssociation:
   Exclude:
+    - 'lib/foreman_discovery/engine.rb'
     - 'test/functional/api/v2/discovery_rules_controller_test.rb'
 
 # Offense count: 2
+# Cop supports --auto-correct.
 Lint/AmbiguousRegexpLiteral:
   Exclude:
     - 'test/functional/api/v2/discovery_rules_controller_test.rb'
     - 'test/unit/discovered_extensions_test.rb'
 
-# Offense count: 4
+# Offense count: 5
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
     - 'app/controllers/api/v2/discovered_hosts_controller.rb'
     - 'app/controllers/discovered_hosts_controller.rb'
+    - 'db/migrate/20150331132115_remove_old_permissions.rb'
 
 # Offense count: 1
+# Cop supports --auto-correct.
 Lint/BooleanSymbol:
   Exclude:
     - 'app/models/discovery_rule.rb'
 
+# Offense count: 2
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: enums
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - 'lib/foreman_discovery/engine.rb'
+
+# Offense count: 1
+Lint/MissingSuper:
+  Exclude:
+    - 'app/services/foreman_discovery/ui_notifications/failed_discovery.rb'
+
 # Offense count: 1
+# Cop supports --auto-correct.
 Lint/ParenthesesAsGroupedExpression:
   Exclude:
     - 'test/unit/discovery_taxonomy_extensions_test.rb'
 
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'db/migrate/20221102065954_fix_discovery_settings_category_to_dsl.rb'
+
 # Offense count: 1
 # Cop supports --auto-correct.
 Lint/RedundantStringCoercion:
   Exclude:
     - 'app/controllers/concerns/foreman/controller/discovered_extensions.rb'
 
-# Offense count: 6
+# Offense count: 7
 Lint/RescueException:
   Exclude:
     - 'app/controllers/api/v2/discovered_hosts_controller.rb'
     - 'app/controllers/concerns/foreman/controller/discovered_extensions.rb'
     - 'app/services/foreman_discovery/node_api/node_resource.rb'
+    - 'app/services/foreman_discovery/subnet_suggestion.rb'
+    - 'db/migrate/20141223142759_fill_discovery_attribute_sets_for_existing_hosts.rb'
 
 # Offense count: 7
 # Cop supports --auto-correct.
@@ -328,6 +444,7 @@ Lint/UnusedBlockArgument:
   Exclude:
     - 'app/models/host/discovered.rb'
     - 'app/services/foreman_discovery/import_hooks/discovery_attribute.rb'
+    - 'extra/discover-host'
     - 'lib/foreman_discovery/engine.rb'
 
 # Offense count: 1
@@ -342,6 +459,49 @@ Lint/UselessAssignment:
     - 'test/unit/discovery_attribute_set_test.rb'
     - 'test/unit/discovery_rule_test.rb'
 
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowComments.
+Lint/UselessMethodDefinition:
+  Exclude:
+    - 'app/models/host/discovered.rb'
+
+# Offense count: 63
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
+Metrics/AbcSize:
+  Max: 78
+
+# Offense count: 20
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine
+Metrics/BlockLength:
+  Max: 255
+
+# Offense count: 11
+# Configuration parameters: CountComments, CountAsOne.
+Metrics/ClassLength:
+  Max: 433
+
+# Offense count: 6
+# Configuration parameters: IgnoredMethods.
+Metrics/CyclomaticComplexity:
+  Max: 20
+
+# Offense count: 48
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+Metrics/MethodLength:
+  Max: 40
+
+# Offense count: 2
+# Configuration parameters: Max, CountKeywordArgs.
+Metrics/ParameterLists:
+  MaxOptionalParameters: 4
+
+# Offense count: 5
+# Configuration parameters: IgnoredMethods.
+Metrics/PerceivedComplexity:
+  Max: 23
+
 # Offense count: 3
 # Cop supports --auto-correct.
 Minitest/AssertEmpty:
@@ -349,16 +509,24 @@ Minitest/AssertEmpty:
     - 'test/functional/api/v2/discovery_rules_controller_test.rb'
     - 'test/unit/host_discovered_test.rb'
 
+# Offense count: 3
+# Cop supports --auto-correct.
+Minitest/AssertEmptyLiteral:
+  Exclude:
+    - 'test/migrations/20221102075151_migrate_discovery_hostname_and_fact_column_to_array_test.rb'
+    - 'test/unit/lldp_neighbors_test.rb'
+
 # Offense count: 2
 # Cop supports --auto-correct.
 Minitest/AssertEqual:
   Exclude:
     - 'test/unit/discovered_extensions_test.rb'
 
-# Offense count: 4
+# Offense count: 5
 # Cop supports --auto-correct.
 Minitest/AssertIncludes:
   Exclude:
+    - 'test/functional/discovered_hosts_controller_test.rb'
     - 'test/unit/discovered_mailer_test.rb'
 
 # Offense count: 1
@@ -375,6 +543,12 @@ Minitest/RefuteFalse:
     - 'test/functional/api/v2/discovery_rules_controller_test.rb'
     - 'test/unit/host_discovered_test.rb'
 
+# Offense count: 1
+# Cop supports --auto-correct.
+Minitest/RefuteNil:
+  Exclude:
+    - 'test/functional/api/v2/discovery_rules_controller_test.rb'
+
 # Offense count: 4
 Naming/AccessorMethodName:
   Exclude:
@@ -383,7 +557,7 @@ Naming/AccessorMethodName:
     - 'app/services/foreman_discovery/host_converter.rb'
     - 'test/test_helper_discovery.rb'
 
-# Offense count: 2
+# Offense count: 3
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
 # SupportedStylesForLeadingUnderscores: disallowed, required, optional
 Naming/MemoizedInstanceVariableName:
@@ -400,7 +574,7 @@ Naming/MethodName:
 
 # Offense count: 1
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
 Naming/MethodParameterName:
   Exclude:
     - 'app/helpers/discovered_hosts_helper.rb'
@@ -413,15 +587,29 @@ Naming/MethodParameterName:
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:
-    - 'spec/**/*'
     - 'app/services/foreman_discovery/node_api/node_resource.rb'
 
-# Offense count: 2
+# Offense count: 1
+# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers.
+# SupportedStyles: snake_case, normalcase, non_integer
+# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339
+Naming/VariableNumber:
+  Exclude:
+    - 'test/test_helper_discovery.rb'
+
+# Offense count: 1
+# Configuration parameters: MinSize.
+Performance/CollectionLiteralInLoop:
+  Exclude:
+    - 'extra/discover-host'
+
+# Offense count: 3
 # Cop supports --auto-correct.
 Performance/RedundantMatch:
   Exclude:
-    - 'app/controllers/discovered_hosts_controller.rb'
     - 'app/models/host/discovered.rb'
+    - 'app/services/foreman_discovery/fact_to_category_resolver.rb'
+    - 'release-gem'
 
 # Offense count: 5
 # Cop supports --auto-correct.
@@ -430,12 +618,28 @@ Performance/RedundantMerge:
   Exclude:
     - 'test/unit/host_discovered_test.rb'
 
-# Offense count: 2
+# Offense count: 7
 # Cop supports --auto-correct.
-Rails/ActiveRecordAliases:
+Performance/RegexpMatch:
   Exclude:
-    - 'app/controllers/api/v2/discovery_rules_controller.rb'
-    - 'app/controllers/discovery_rules_controller.rb'
+    - 'app/models/host/discovered.rb'
+    - 'app/models/host/managed_extensions.rb'
+    - 'app/services/foreman_discovery/fact_to_category_resolver.rb'
+    - 'release-gem'
+    - 'test/test_helper_discovery.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect.
+Performance/TimesMap:
+  Exclude:
+    - 'extra/discover-host'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Rails/ApplicationRecord:
+  Exclude:
+    - 'db/migrate/20180412124505_add_priority_score_to_discovery_rules.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -446,27 +650,48 @@ Rails/AssertNot:
     - 'test/functional/api/v2/discovered_hosts_controller_test.rb'
     - 'test/functional/api/v2/discovery_rules_controller_test.rb'
 
-# Offense count: 34
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
+Rails/Blank:
+  Exclude:
+    - 'app/models/host/discovered.rb'
+    - 'app/services/foreman_discovery/host_converter.rb'
+
+# Offense count: 39
 # Cop supports --auto-correct.
-# Configuration parameters: Whitelist.
+# Configuration parameters: Whitelist, AllowedMethods, AllowedReceivers.
 # Whitelist: find_by_sql
+# AllowedMethods: find_by_sql
+# AllowedReceivers: Gem::Specification
 Rails/DynamicFindBy:
   Exclude:
     - 'app/controllers/discovered_hosts_controller.rb'
     - 'app/services/foreman_discovery/import_hooks/lock_templates.rb'
     - 'app/services/foreman_discovery/import_hooks/subnet_and_taxonomy.rb'
-    - 'test/functional/api/v2/settings_controller_test.rb'
+    - 'db/migrate/20150714144500_review_discovery_permissions.rb'
+    - 'db/migrate/20151023144501_regenerate_red_hat_kexec.rb'
+    - 'db/migrate/20160805104605_rename_lock_template_setting.rb'
+    - 'db/seeds.d/90_add_permissions_from_default_roles.rb'
+    - 'lib/foreman_discovery/engine.rb'
     - 'test/test_helper_discovery.rb'
     - 'test/unit/discovered_extensions_test.rb'
     - 'test/unit/host_discovered_test.rb'
     - 'test/unit/managed_extensions_test.rb'
 
 # Offense count: 1
+# Cop supports --auto-correct.
+Rails/EnvironmentComparison:
+  Exclude:
+    - 'app/services/foreman_discovery/node_api/node_resource.rb'
+
+# Offense count: 2
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/HasManyOrHasOneDependent:
   Exclude:
     - 'app/models/concerns/discovery_taxonomy_extensions.rb'
+    - 'app/models/host/discovered.rb'
 
 # Offense count: 1
 # Configuration parameters: Include.
@@ -499,19 +724,30 @@ Rails/OutputSafety:
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, flexible
-Rails/TimeZone:
+Rails/RedundantForeignKey:
   Exclude:
-    - 'app/models/host/discovered.rb'
+    - 'app/models/discovery_attribute_set.rb'
+
+# Offense count: 47
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, Include.
+# SupportedStyles: assert_not, refute
+# Include: **/test/**/*
+Rails/RefuteMethods:
+  Exclude:
+    - 'test/functional/api/v2/discovered_hosts_controller_test.rb'
+    - 'test/functional/api/v2/discovery_rules_controller_test.rb'
+    - 'test/unit/discovered_extensions_test.rb'
+    - 'test/unit/discovery_taxonomy_extensions_test.rb'
+    - 'test/unit/host_discovered_test.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: Include.
-# Include: app/models/**/*.rb
-Rails/Validation:
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: strict, flexible
+Rails/TimeZone:
   Exclude:
-    - 'app/models/discovery_rule.rb'
+    - 'app/services/foreman_discovery/host_fact_importer.rb'
 
 # Offense count: 4
 # Cop supports --auto-correct.
@@ -522,26 +758,51 @@ Style/AndOr:
     - 'app/controllers/discovered_hosts_controller.rb'
     - 'app/services/foreman_discovery/node_api/node_resource.rb'
 
-# Offense count: 15
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# IgnoredMethods: lambda, proc, it
+Style/BlockDelimiters:
+  Exclude:
+    - 'lib/foreman_discovery/engine.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/CaseLikeIf:
+  Exclude:
+    - 'app/models/host/discovered.rb'
+
+# Offense count: 12
 # Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle.
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Exclude:
     - 'app/controllers/concerns/foreman/controller/discovered_extensions.rb'
-    - 'app/controllers/concerns/foreman/controller/parameters/discovered_host.rb'
-    - 'app/controllers/concerns/foreman/controller/parameters/discovery_rule.rb'
     - 'app/models/host/discovered.rb'
     - 'app/models/host/managed_extensions.rb'
     - 'app/models/nic/managed_extensions.rb'
     - 'app/services/foreman_discovery/host_converter.rb'
+    - 'app/services/foreman_discovery/host_fact_importer.rb'
     - 'app/services/foreman_discovery/node_api/inventory.rb'
     - 'app/services/foreman_discovery/node_api/node_resource.rb'
     - 'app/services/foreman_discovery/node_api/power.rb'
     - 'app/services/foreman_discovery/node_api/power_service.rb'
     - 'test/functional/api/v2/discovered_hosts_controller_test.rb'
     - 'test/functional/api/v2/discovery_rules_controller_test.rb'
-    - 'test/functional/api/v2/settings_controller_test.rb'
+    - 'app/controllers/concerns/foreman/controller/parameters/discovered_host.rb'
+    - 'app/controllers/concerns/foreman/controller/parameters/discovery_rule.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: is_a?, kind_of?
+Style/ClassCheck:
+  Exclude:
+    - 'app/mailers/discovered_mailer.rb'
 
 # Offense count: 6
 # Cop supports --auto-correct.
@@ -551,19 +812,25 @@ Style/ColonMethodCall:
     - 'app/services/foreman_discovery/fact_parser.rb'
     - 'test/functional/api/v2/discovered_hosts_controller_test.rb'
 
-# Offense count: 1
+# Offense count: 7
 # Cop supports --auto-correct.
-Style/EmptyLiteral:
+# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
+# SupportedStyles: assign_to_condition, assign_inside_condition
+Style/ConditionalAssignment:
   Exclude:
-    - 'app/controllers/discovered_hosts_controller.rb'
+    - 'app/helpers/discovery_rules_helper.rb'
+    - 'app/models/host/discovered.rb'
+    - 'lib/discovery.rake'
+    - 'test/functional/discovered_hosts_controller_test.rb'
+    - 'test/unit/discovered_extensions_test.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
-Style/ExpandPathArguments:
+Style/ExplicitBlockArgument:
   Exclude:
-    - 'lib/foreman_discovery/engine.rb'
+    - 'test/test_helper_discovery.rb'
 
-# Offense count: 13
+# Offense count: 14
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: format, sprintf, percent
@@ -573,9 +840,10 @@ Style/FormatString:
     - 'app/controllers/discovered_hosts_controller.rb'
     - 'app/models/host/discovered.rb'
     - 'app/services/foreman_discovery/fact_parser.rb'
+    - 'extra/discover-host'
 
-# Offense count: 36
-# Configuration parameters: EnforcedStyle.
+# Offense count: 39
+# Configuration parameters: EnforcedStyle, MaxUnannotatedPlaceholdersAllowed, IgnoredMethods.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
   Exclude:
@@ -585,7 +853,26 @@ Style/FormatStringToken:
     - 'app/services/foreman_discovery/fact_parser.rb'
     - 'app/services/foreman_discovery/node_api/node_resource.rb'
 
-# Offense count: 7
+# Offense count: 106
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/GlobalStdStream:
+  Exclude:
+    - 'release-gem'
+
+# Offense count: 21
+# Configuration parameters: AllowedVariables.
+Style/GlobalVars:
+  Exclude:
+    - 'release-gem'
+
+# Offense count: 10
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
@@ -594,6 +881,51 @@ Style/GuardClause:
     - 'app/models/discovery_rule.rb'
     - 'app/models/host/discovered.rb'
     - 'app/services/foreman_discovery/node_api/node_resource.rb'
+    - 'db/migrate/20150331132115_remove_old_permissions.rb'
+    - 'db/migrate/20161006094714_add_constraints_on_subnets_smart_proxies.rb'
+    - 'test/functional/discovered_hosts_controller_test.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: braces, no_braces
+Style/HashAsLastArrayItem:
+  Exclude:
+    - 'app/helpers/discovered_hosts_helper.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowedReceivers.
+Style/HashEachMethods:
+  Exclude:
+    - 'app/services/foreman_discovery/import_hooks/discovery_attribute.rb'
+    - 'app/services/foreman_discovery/lldp_neighbors.rb'
+
+# Offense count: 1080
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+Style/HashSyntax:
+  Enabled: false
+
+# Offense count: 11
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'app/controllers/concerns/foreman/controller/discovered_extensions.rb'
+    - 'app/controllers/concerns/foreman/controller/parameters/discovered_host.rb'
+    - 'app/controllers/discovered_hosts_controller.rb'
+    - 'db/migrate/20161006094714_add_constraints_on_subnets_smart_proxies.rb'
+    - 'lib/foreman_discovery/engine.rb'
+    - 'test/integration/discovered_hosts_test.rb'
+    - 'test/test_plugin_helper.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: InverseMethods, InverseBlocks.
+Style/InverseMethods:
+  Exclude:
+    - 'app/controllers/discovered_hosts_controller.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
@@ -602,7 +934,7 @@ Style/GuardClause:
 Style/LambdaCall:
   EnforcedStyle: braces
 
-# Offense count: 5
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
@@ -610,6 +942,7 @@ Style/MethodDefParentheses:
   Exclude:
     - 'app/controllers/concerns/foreman/controller/discovered_extensions.rb'
     - 'app/models/host/discovered.rb'
+    - 'extra/discover-host'
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -617,7 +950,7 @@ Style/MultilineIfModifier:
   Exclude:
     - 'app/services/foreman_discovery/fact_parser.rb'
 
-# Offense count: 3
+# Offense count: 5
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: literals, strict
@@ -626,6 +959,7 @@ Style/MutableConstant:
     - 'app/services/foreman_discovery/import_hook_service.rb'
     - 'lib/foreman_discovery/engine.rb'
     - 'lib/foreman_discovery/version.rb'
+    - 'release-gem'
 
 # Offense count: 3
 # Cop supports --auto-correct.
@@ -649,18 +983,57 @@ Style/Next:
 Style/NumericLiterals:
   MinDigits: 7
 
-# Offense count: 9
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, IgnoredMethods.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'app/controllers/api/v2/discovered_hosts_controller.rb'
+    - 'app/controllers/concerns/foreman/controller/discovered_extensions.rb'
+    - 'app/controllers/discovered_hosts_controller.rb'
+    - 'app/helpers/discovered_hosts_helper.rb'
+    - 'app/models/host/discovered.rb'
+    - 'app/services/foreman_discovery/fact_parser.rb'
+    - 'app/services/foreman_discovery/import_hooks/discovery_attribute.rb'
+    - 'db/migrate/20150331132115_remove_old_permissions.rb'
+    - 'test/unit/discovery_rule_test.rb'
+
+# Offense count: 3
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'app/services/foreman_discovery/host_converter.rb'
+    - 'test/test_helper_discovery.rb'
+
+# Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
   Exclude:
     - 'app/controllers/api/v2/discovered_hosts_controller.rb'
     - 'app/controllers/api/v2/discovery_rules_controller.rb'
+    - 'foreman_discovery.gemspec'
     - 'test/unit/lldp_neighbors_test.rb'
 
-# Offense count: 9
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
+# SupportedStyles: short, verbose
+Style/PreferredHashMethods:
+  Exclude:
+    - 'app/services/foreman_discovery/lldp_neighbors.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/Proc:
+  Exclude:
+    - 'lib/foreman_discovery/engine.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, AllowedCompactTypes.
 # SupportedStyles: compact, exploded
 Style/RaiseArgs:
   Exclude:
@@ -669,20 +1042,22 @@ Style/RaiseArgs:
     - 'app/models/host/managed_extensions.rb'
     - 'app/services/foreman_discovery/fact_parser.rb'
 
-# Offense count: 8
+# Offense count: 9
 # Cop supports --auto-correct.
 Style/RedundantBegin:
   Exclude:
     - 'app/controllers/concerns/foreman/controller/discovered_extensions.rb'
     - 'app/models/host/discovered.rb'
+    - 'db/migrate/20141223142759_fill_discovery_attribute_sets_for_existing_hosts.rb'
     - 'test/unit/discovery_attribute_set_test.rb'
     - 'test/unit/host_discovered_test.rb'
 
-# Offense count: 1
+# Offense count: 2
 # Cop supports --auto-correct.
 Style/RedundantCondition:
   Exclude:
     - 'app/controllers/discovered_hosts_controller.rb'
+    - 'extra/discover-host'
 
 # Offense count: 1
 # Cop supports --auto-correct.
@@ -690,7 +1065,20 @@ Style/RedundantParentheses:
   Exclude:
     - 'app/controllers/discovery_rules_controller.rb'
 
-# Offense count: 4
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantPercentQ:
+  Exclude:
+    - 'foreman_discovery.gemspec'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RedundantRegexpEscape:
+  Exclude:
+    - 'release-gem'
+    - 'test/test_helper_discovery.rb'
+
+# Offense count: 5
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleReturnValues.
 Style/RedundantReturn:
@@ -700,32 +1088,30 @@ Style/RedundantReturn:
     - 'app/models/host/discovered.rb'
     - 'app/services/foreman_discovery/node_api/node_resource.rb'
 
-# Offense count: 35
+# Offense count: 18
 # Cop supports --auto-correct.
 Style/RedundantSelf:
   Exclude:
-    - 'app/models/discovery_rule.rb'
     - 'app/models/host/discovered.rb'
     - 'app/models/host/managed_extensions.rb'
     - 'app/models/nic/managed_extensions.rb'
     - 'app/services/foreman_discovery/lldp_neighbors.rb'
 
-# Offense count: 4
+# Offense count: 5
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
 # SupportedStyles: slashes, percent_r, mixed
 Style/RegexpLiteral:
   Exclude:
-    - 'test/functional/discovered_hosts_controller_test.rb'
+    - 'config/routes.rb'
     - 'test/functional/discovery_rules_controller_test.rb'
     - 'test/unit/managed_extensions_test.rb'
 
-# Offense count: 5
+# Offense count: 4
 # Cop supports --auto-correct.
 Style/RescueModifier:
   Exclude:
     - 'app/services/foreman_discovery/import_hooks/discovery_attribute.rb'
-    - 'lib/foreman_discovery/engine.rb'
     - 'test/test_helper_discovery.rb'
 
 # Offense count: 8
@@ -738,13 +1124,15 @@ Style/RescueStandardError:
     - 'app/models/host/discovered.rb'
     - 'app/services/foreman_discovery/node_api/node_resource.rb'
 
-# Offense count: 2
+# Offense count: 5
 # Cop supports --auto-correct.
 # Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
 # AllowedMethods: present?, blank?, presence, try, try!
 Style/SafeNavigation:
   Exclude:
     - 'app/models/host/discovered.rb'
+    - 'db/migrate/20151023144501_regenerate_red_hat_kexec.rb'
+    - 'db/migrate/20160805104605_rename_lock_template_setting.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
@@ -753,23 +1141,64 @@ Style/SingleLineMethods:
   Exclude:
     - 'app/services/foreman_discovery/node_api/node_resource.rb'
 
-# Offense count: 1
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: RequireEnglish.
+# SupportedStyles: use_perl_names, use_english_names
+Style/SpecialGlobalVars:
+  EnforcedStyle: use_perl_names
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: Mode.
+Style/StringConcatenation:
+  Exclude:
+    - 'app/models/host/managed_extensions.rb'
+    - 'app/services/foreman_discovery/lldp_neighbors.rb'
+    - 'app/services/foreman_discovery/node_api/inventory.rb'
+    - 'app/services/foreman_discovery/node_api/power_service.rb'
+    - 'extra/discover-host'
+    - 'test/factories/discovery_host_related.rb'
+    - 'test/unit/discovery_rule_test.rb'
+
+# Offense count: 1000
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Enabled: false
+
+# Offense count: 28
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, MinSize.
 # SupportedStyles: percent, brackets
 Style/SymbolArray:
   Exclude:
-    - 'test/integration/discovered_hosts_test.rb'
+    - 'app/controllers/discovered_hosts_controller.rb'
+    - 'app/controllers/discovery_rules_controller.rb'
+    - 'config/routes.rb'
+    - 'lib/foreman_discovery/engine.rb'
+    - 'test/functional/discovered_hosts_controller_test.rb'
+    - 'test/unit/discovered_extensions_test.rb'
 
-# Offense count: 2
+# Offense count: 3
 # Cop supports --auto-correct.
-# Configuration parameters: IgnoredMethods.
+# Configuration parameters: AllowMethodsWithArguments, IgnoredMethods.
 # IgnoredMethods: respond_to, define_method
 Style/SymbolProc:
   Exclude:
+    - 'extra/discover-host'
     - 'test/functional/api/v2/discovery_rules_controller_test.rb'
 
-# Offense count: 2
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+Style/TrailingCommaInArguments:
+  Exclude:
+    - 'app/services/foreman_discovery/ui_notifications/failed_discovery.rb'
+
+# Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
@@ -777,8 +1206,10 @@ Style/TrailingCommaInArrayLiteral:
   Exclude:
     - 'app/controllers/discovered_hosts_controller.rb'
     - 'app/services/foreman_discovery/import_hook_service.rb'
+    - 'foreman_discovery.gemspec'
+    - 'test/migrations/20221102075151_migrate_discovery_hostname_and_fact_column_to_array_test.rb'
 
-# Offense count: 31
+# Offense count: 32
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
@@ -792,6 +1223,7 @@ Style/TrailingCommaInHashLiteral:
     - 'test/functional/api/v2/discovery_rules_controller_test.rb'
     - 'test/functional/discovered_hosts_controller_test.rb'
     - 'test/functional/foreman_discovery/concerns/hosts_controller_extensions_test.rb'
+    - 'test/test_helper_discovery.rb'
     - 'test/unit/fact_parser_test.rb'
     - 'test/unit/managed_extensions_test.rb'
 
@@ -801,9 +1233,25 @@ Style/UnlessElse:
   Exclude:
     - 'app/controllers/api/v2/discovered_hosts_controller.rb'
 
-# Offense count: 2
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: WordRegex.
+# SupportedStyles: percent, brackets
+Style/WordArray:
+  EnforcedStyle: percent
+  MinSize: 4
+
+# Offense count: 3
 # Cop supports --auto-correct.
 Style/ZeroLengthPredicate:
   Exclude:
     - 'app/controllers/concerns/foreman/controller/discovered_extensions.rb'
     - 'app/services/foreman_discovery/fact_parser.rb'
+    - 'db/migrate/20150331132115_remove_old_permissions.rb'
+
+# Offense count: 153
+# Cop supports --auto-correct.
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 287
diff --git a/Gemfile b/Gemfile
index 1c86af95d..c08bfb802 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,3 +2,4 @@ source "http://rubygems.org"
 
 gemspec
 
+gem 'theforeman-rubocop', '~> 0.1.0'