Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg:generate_source already prints the path to the tarball #946

Merged
merged 1 commit into from
May 14, 2024
Merged

pkg:generate_source already prints the path to the tarball #946

merged 1 commit into from
May 14, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented May 14, 2024

create-archive needs to "return" (print) the path, but there is no need to do it twice

@evgeni
pkg:generate_source already prints the path to the tarball
c16b6b3 
create-archive needs to "return" (print) the path, but there is no need to do it twice
ekohl
ekohl approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew 6dcf5bf would one day come in handy.

@ekohl ekohl merged commit f629938 into develop May 14, 2024
8 checks passed
@ekohl ekohl deleted the packit-simple-generate branch May 14, 2024 19:34
@evgeni
Copy link
Member Author

evgeni commented May 14, 2024

I knew 6dcf5bf would one day come in handy.

1887 days later… ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehelms ehelms ehelms approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgeni @ekohl @ehelms