From 883731698334f794a5421867fa1ca79d96e5a94d Mon Sep 17 00:00:00 2001 From: Samir Jha Date: Tue, 6 Aug 2024 13:01:43 -0400 Subject: [PATCH] Fixes #37717 - Update evr extension ownership to foreman --- hooks/boot/01-kafo-hook-extensions.rb | 11 ++++++++ .../pre/35-change-evr-extension-ownership.rb | 25 +++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 hooks/pre/35-change-evr-extension-ownership.rb diff --git a/hooks/boot/01-kafo-hook-extensions.rb b/hooks/boot/01-kafo-hook-extensions.rb index 21c596fe..41310e5f 100644 --- a/hooks/boot/01-kafo-hook-extensions.rb +++ b/hooks/boot/01-kafo-hook-extensions.rb @@ -85,6 +85,12 @@ def pulpcore_enabled? module_enabled?('foreman_proxy_content') end + def local_db_exists?(database = 'foreman') + db_existence_command = pg_sql_statement("SELECT 1 FROM pg_database WHERE datname = '#{database}';") + db_existence_output, = execute_as_formatted!('postgres', db_existence_command, false, true) + db_existence_output&.strip == '1' + end + def log_and_say(level, message, do_say = true, do_log = true) style = case level when :error @@ -164,6 +170,11 @@ def execute_as!(user, command, do_say = true, do_log = true, extra_env = {}) execute!(runuser_command, do_say, do_log, extra_env) end + def execute_as_formatted!(user, command, do_say = true, do_log = true, extra_env = {}) + runuser_command = ['runuser', '-l', user, '-c', command] + execute_command(runuser_command, do_say, do_log, extra_env) + end + def execute(command, do_say, do_log, extra_env = {}) _stdout_stderr, status = execute_command(command, do_say, do_log, extra_env) status diff --git a/hooks/pre/35-change-evr-extension-ownership.rb b/hooks/pre/35-change-evr-extension-ownership.rb new file mode 100644 index 00000000..349485b0 --- /dev/null +++ b/hooks/pre/35-change-evr-extension-ownership.rb @@ -0,0 +1,25 @@ +# In Katello 4.16, the 'evr' extension is removed from PostgreSQL and integrated into the Katello database via a migration. +# This hook ensures the 'evr' extension's ownership is transferred to the 'foreman' user so migrations can act on it. + +if (local_foreman_db? || devel_scenario?) && execute("rpm -q postgresql-evr", false, false) + if app_value(:noop) + logger.debug("Would start postgresql service") + else + start_services(['postgresql']) + end + + database = param_value('foreman', 'db_database') || 'foreman' + username = param_value('foreman', 'db_username') || 'foreman' + + if local_db_exists?(database) + sql = "UPDATE pg_extension SET extowner = (SELECT oid FROM pg_authid WHERE rolname='#{username}') WHERE extname='evr'" + if app_value(:noop) + logger.debug("Would execute: #{sql} to update ownership of the evr extension") + else + logger.debug("Updating ownership of the evr extension") + execute_as_formatted!('postgres', "psql -d #{database} -c \"#{sql}\"", false, true) + end + else + logger.debug("The foreman database does not exist.") + end +end