Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify it works with all plugins #1

Closed
26 of 29 tasks
ekohl opened this issue Mar 14, 2022 · 25 comments
Closed
26 of 29 tasks

Verify it works with all plugins #1

ekohl opened this issue Mar 14, 2022 · 25 comments

Comments

@ekohl
Copy link
Member

ekohl commented Mar 14, 2022

@ekohl
Copy link
Member Author

ekohl commented Mar 14, 2022

At least foreman_dlm does something extra that's not captured yet: precompile the assets in a production environment:
https://github.com/dm-drogeriemarkt/foreman_dlm/blob/56af16ae462e5216054473432826cfa235ff26e3/.github/workflows/ci.yml#L77-L84

It also uses nick-fields/retry@v2 to retry failing tests.

@ekohl
Copy link
Member Author

ekohl commented Mar 14, 2022

Another thing that is missing is the caching only step on push. This would be to just install the gems, which builds a cache. If that's done when pushing to master, all PRs can benefit the cache. Otherwise the cache is stored in the PR owners repo.

@ekohl
Copy link
Member Author

ekohl commented Mar 14, 2022

Another note to self:

@ofedoren
Copy link
Member

Just to update plugins list: https://github.com/theforeman/foreman_webhooks

@ekohl
Copy link
Member Author

ekohl commented Mar 15, 2022

Thanks. I found the list by doing ls ~/dev/foreman_*/.github/workflows so it looks like locally I don't have it checked out.

@ekohl
Copy link
Member Author

ekohl commented Mar 15, 2022

More notes to self: github.head_ref is only available in the PR context, not on push.

@ekohl
Copy link
Member Author

ekohl commented Apr 4, 2022

REX also has:

      - name: 'Upload logs'
        uses: actions/upload-artifact@v2
        if: failure()
        with:
          name: logs
          path: log/*.log
          retention-days: 5

@ekohl
Copy link
Member Author

ekohl commented Oct 31, 2023

foreman_ansible has the same log upload and also has rake webpack:compile.

@archanaserver
Copy link

@ekohl
Copy link
Member Author

ekohl commented Jan 12, 2024

In light of https://community.theforeman.org/t/convert-foreman-plugins-continuous-integration-to-github-actions/35917 I've expanded the list with all plugins shipped in Satellite and those currently testing in Jenkins. It already included all plugins that had previous actions.

@adamruzicka
Copy link

adamruzicka commented Jan 12, 2024

@adamruzicka
Copy link

@ofedoren
Copy link
Member

@archanaserver
Copy link

@archanaserver
Copy link

@archanaserver
Copy link

@archanaserver
Copy link

@archanaserver
Copy link

@archanaserver
Copy link

@archanaserver
Copy link

@archanaserver
Copy link

archanaserver commented Jan 25, 2024

@archanaserver
Copy link

Dropping this here, to keep everything on track: #38

@dosas
Copy link

dosas commented Feb 23, 2024

@ekohl
Copy link
Member Author

ekohl commented Feb 26, 2024

https://github.com/theforeman/foreman_maintain

This is not Foreman plugin, even though the name implies it so the Foreman plugin workflow doesn't apply.

@ekohl
Copy link
Member Author

ekohl commented Mar 7, 2024

Closing since it's implemented for the majority. https://github.com/orgs/theforeman/projects/10/views/1 tracks what's remaining now.

@ekohl ekohl closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

5 participants