Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heun 2nd order coupling #547

Open
maedoc opened this issue Apr 1, 2022 · 0 comments
Open

Heun 2nd order coupling #547

maedoc opened this issue Apr 1, 2022 · 0 comments
Assignees
Labels
area/scilib bug Something isn't working

Comments

@maedoc
Copy link
Member

maedoc commented Apr 1, 2022

Describe the bug

In the current integrators, the coupling has been evaluated only once per step, while the Heun method should evaluate it twice. For many models, this isn't an issue, but some models have highly nonlinear coupling functions (e.g. Kuramoto) and convergence suffers significantly compared to custom code (10x smaller time step required).

Steps to reproduce

Any model even with linear coupling, e.g. Kuramoto or MPR.

Expected results

Faster convergence.

Actual results

Slow convergence.

Additional information

This will require a change to data flow as the integrator does not currently receive the coupling function instance as an argument.

@maedoc maedoc self-assigned this Apr 1, 2022
@maedoc maedoc added bug Something isn't working area/scilib labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scilib bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant