You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reduced set models are quite slow and should be improved as with other models in the TVB library.
Describe your proposed implementation
The dfun implementations can be replaced by Numba functions with explicit loops, which will provide an immediate speed up with the default backend.
Describe possible alternatives
The differential equations could annotated as with the MPR model to make them compatible with the Numba code gen backend. The backend may need to be taught to generate code for the mode coupling.
The dfun method linked to in the issue is a bottleneck for simulations using this model. This issue would involve writing a new implementation with Numba. This can be approached by writing a benchmark of the current code, creating a second implementation, checking the second implementation produces identical results as the first, and finally checking that the second implementation is faster.
Thanks for the detailed explanation. I’ll start working on this issue using the information you’ve provided. I’ve observed Numba implementations in other models and I think they can be used as references for this task.
Hello,
I've tried re-implementing the dfun functions, but unfortunately, the results are not identical to the previous implementation. I've attached a PR for your review. Could you please take a look and provide any feedback ?
Thank you
Describe the new feature or enhancement
The reduced set models are quite slow and should be improved as with other models in the TVB library.
Describe your proposed implementation
The dfun implementations can be replaced by Numba functions with explicit loops, which will provide an immediate speed up with the default backend.
Describe possible alternatives
The differential equations could annotated as with the MPR model to make them compatible with the Numba code gen backend. The backend may need to be taught to generate code for the mode coupling.
Additional comments
Following a request from the TVB list this morning, cf https://groups.google.com/g/tvb-users/c/GovsAb-xc1k/m/vCTOQcd_FAAJ
The text was updated successfully, but these errors were encountered: