Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-dom can be removed from peer dependency #34

Open
nikechanhk opened this issue Aug 31, 2022 · 1 comment
Open

react-dom can be removed from peer dependency #34

nikechanhk opened this issue Aug 31, 2022 · 1 comment

Comments

@nikechanhk
Copy link

The source code here seems don't have any code is related to UI or dom.
I think react-dom can be removed so that react native proj also can use this awesome library
@rwieruch
Copy link
Member

If you create a PR which removes the dependency and you can confirm that the library works in a React/React Native project, I'd be happy to merge it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwieruch @nikechanhk