Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-task issue includes small refactors, styling, and cleaning up some code organization #89

Closed
4 tasks done
krsnamara opened this issue Apr 6, 2024 · 0 comments · Fixed by #90
Closed
4 tasks done
Assignees
Labels

Comments

@krsnamara
Copy link
Collaborator

krsnamara commented Apr 6, 2024

Summary

Paint the list page and Manage list page with app colors and global styling.
The search and create inputs need some touching up to remove default styling.

There are two redirects that do not make sense and need to be updated. One is after sign in the user stays on the landing page which then they must navigate by clicking the 'show me the lists' button. The other is when a user deletes a list they are pushed to the manage list url. Ideally they would remain on the lists page.

The imports section of the code changes from page to page. This would look cleaner if each of the files had similar locations for react specific imports, followed by app function or prop imports, and lastly the css import. In addition some of the imports from a specific directory does not use the index.js declarations of 'export * from ....".
Go through each file and apply this structure update.

Acceptance criteria

  • Ensure the list page and Manage list page adhere to app colors and global styling.
  • Refine search and create inputs by eliminating default styling and paint with app colors.
  • Update redirects post sign-in and delete list to navigate users to the lists page instead of the landing page or keep users on the lists page after deleting a list
  • standardize import structure across files for React, app functions/props, and CSS, ensuring index.js declarations are used for exports.

Notes

Sub-issue of #14
Related to #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant