Upcoming Match in Notifications view shows wrong alliance colors

[1fish2]

In the Notifications view, "Upcoming match" notifications show wrong alliance colors while "Match result" notifications show the right alliance colors.

(I'd take a screenshot that shows both but Android Monitor just freezes up. This SO answer says the workaround is to downgrade to JDK 1.8.0_151. In the best of all worlds, upgrading to JDK 8u162 would fix it, but I'll find out after the download finishes someday.)

Here's @fangeugene's screenshot:

[1fish2]

Downgrading to JDK 1.8.0_151 did fix Android Monitor, and here's the screenshot:

[bherbst]

Looking at the implementation, it looks like the intent was:

• Orange = upcoming match
• Red = alliance selection notification
• Blue = match results notification

So unless the desire is to show red/blue depending on a particular followed team's alliance color, I think we are doing the correct thing. That would get messy if you were following teams that played against each other, so I'm not sure how feasible that would be.

[1fish2]

After 6 years, it's fair to drop this. (Maybe fixed by now?)

Note that the bug is about the (light) red/blue alliance colors, not the orange/red/blue section headers.

In the second screenshot, 971+972+973 was the red alliance in 2018 CASF Final 1 Match 2 so they should be red in the "Upcoming Match: Final 1 Match 2" entry as they are in the "Match result: Final 1 Match 2" entry.

[bherbst]

Ahh, looks like 6 years ago Bryan didn't understand which color was wrong 😆
Will take another look