Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoughts on ConditionPathExsists #3

Open
bjerkins opened this issue May 9, 2018 · 1 comment
Open

Thoughts on ConditionPathExsists #3

bjerkins opened this issue May 9, 2018 · 1 comment
Assignees
@tfoldi
Labels
enhancement

Comments

@bjerkins
Copy link

bjerkins commented May 9, 2018

Hey !

Nice image, thanks for sharing.

What's your thought behind the commented out ConditionPathExists

I guess there's a missing part here what to do if we have already made all the initialisation and we restart the container ? Shouldn't something like tableau-start.sh systemd service be created instead , which simply calls tsm initialize ?

Thanks !
@tfoldi
Copy link
Owner

tfoldi commented May 10, 2018

You are absolutely right, one of the forks implements this - and I always wanted to back-merge. If you send a PR I would appreciate otherwise I will do it myself when I have some time and bump it to 2018.1

@tfoldi tfoldi self-assigned this May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfoldi tfoldi

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfoldi @bjerkins