Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More faster init cache creation #300

Closed
wants to merge 1 commit into from
Closed

More faster init cache creation #300

wants to merge 1 commit into from

Conversation

ilnarildarovuch
Copy link

Refactored randomx_init_dataset function in src/randomx.cpp -> running faster, than normal about .8 seconds.
Tested on Windows 11.

@ilnarildarovuch
Copy link
Author

Retested 30 times, with some apps open and closed, result -> 0.2

@SChernykh
Copy link
Collaborator

src/vm_compiled.cpp is only whitespace changes, it shouldn't be here. Keep the diff is small as possible - don't change whitespace or move * around, because it breaks commit history and git blame functionality.

randomx_init_cache takes at most 0.0001 seconds itself, the actual initialization is done inside cache->initialize. Removing a single copy of a short string doesn't make any real difference.

It is very unlikely to be merged for these reasons.

@ilnarildarovuch
Copy link
Author

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants