Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 JIT: don't use x18 register #281

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

SChernykh
Copy link
Collaborator

From https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms

The platforms reserve register x18. Don’t use this register.

This PR fixes invalid hashes when running on Apple silicon with the latest macOS SDK.

@selsta
Copy link
Contributor

selsta commented Oct 19, 2023

./randomx-tests and ./randomx-benchmark --mine --init 10 --threads 10 --jit --nonces 1000000 both pass now with the latest macOS SDK.

@tobtoht
Copy link

tobtoht commented Oct 19, 2023

Tested on a M1 and M2. Tests pass.

./randomx-benchmark --mine --init 10 --threads 10 --jit --nonces 1000000 produces b4b51690546a44a459ad3e043369e1237f61c5ec27046d2f5249cf0b3f57e00c.

Copy link
Collaborator

@hyc hyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still no problems on M1 Macbook pro running MacOS 12.6.5, build 21G531, clang 13.0

@SChernykh SChernykh merged commit d3c9648 into tevador:master Oct 19, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants