feat(waitFor): Automatically advance Jest fake timers #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for react-hooks-testing-library failed.
|
eps1lon
force-pushed
the
feat/waitfor-jest-fake-timers
branch
from
30e6f0f to
18bfadf
Compare
eps1lon
commented
Aug 26, 2022
| // to resolve before continuing. We don't need to take advantage | ||
| // of parallelization so we're fine. | ||
| // https://stackoverflow.com/a/59243586/971592 | ||
| await act(async () => { |
There was a problem hiding this comment.
This is useless for React 17 and should be removed to not confuse. It is only needed in 18 where we need to remove the act from waitFor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Closes #873
Why:
There's little value in
waitForif one has to advance timers by themselves.How:
Copy implementation from
@testing-library/dom.There's an opportunity to write a more generic
waitForthat we can share across Testing Library that specific host configs build on top on (e.g. also running MutationObserver in/dom). But that requires more coordination (starting with an extensive test suite). For now this hopefully suffices (pending testing in actual codebases).Checklist: