Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cars merge into a single null car when no names have been set after a reboot #3183

Closed
1 task done
ebringas opened this issue Apr 14, 2023 · 48 comments
Closed
1 task done
Labels

Comments

@ebringas
Copy link

ebringas commented Apr 14, 2023

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

I'm on edge version, after the database was upgraded now the cars merge into a single null as I don't haven’t put any names to them.

before they just showed the VIN, and now I have to go into the DB and put something into the table "Cars" in the column "Name" for it to correctly show data separated for each car, and this I have to do each time the rpi is rebooted

Expected Behavior

Each car data is grouped together even if the cars have no name, for display purposes the car name can be used and if this field is null then use the VIN

Steps To Reproduce

No response

Relevant log output

...

Screenshots

DB

Grafana

Settings

Additional data

No response

Type of installation

Docker

Version

1.28.0-dev

@ebringas ebringas changed the title Cars merge into a single null car when no names have been set after database upgrade Cars merge into a single null car when no names have been set after a reboot Apr 22, 2023
@refrain
Copy link

refrain commented Apr 26, 2023

I'm having the same issue. 2 cars 1 null. Both unnamed.

I think something might have changed on Tesla's end too, as the official Tesla phone app used to show the vins when they were unnamed as well. Few weeks ago (months?) it changed to "Model 3/Y" in the app.

@lukkigi
Copy link

lukkigi commented Apr 27, 2023

I'm having the same issue. I can name them manually via the PSQL shell and once the container restarts, the names are gone again

@ebringas
Copy link
Author

In the mean time I’ve created a flow on nodered that runs after a reboot and puts a name back, putting a name in the DB doesn’t name the car in tesla systems just locally in teslamate

@Nakatomi2010
Copy link

I'm also running into this issue now.

I'm thinking it's an issue with one of the updates I recently installed to the Ubuntu server that runs the container that is TeslaMate.

If I reboot it, it picks up the car names right away, and then nukes the names after a bit.

Seems to be something with the syncing back to Tesla. I have an older car, that I don't own anymore, in TeslaMate which is not getting renamed after awhile, compared the other two cars I own which are getting renamed.

So, I'm wondering if there was an API change, or something, that needs to be investigated again.

@igeryu
Copy link

igeryu commented Jun 7, 2023

I'm also running into this issue now.

I'm thinking it's an issue with one of the updates I recently installed to the Ubuntu server that runs the container that is TeslaMate.

If I reboot it, it picks up the car names right away, and then nukes the names after a bit.

Seems to be something with the syncing back to Tesla. I have an older car, that I don't own anymore, in TeslaMate which is not getting renamed after awhile, compared the other two cars I own which are getting renamed.

So, I'm wondering if there was an API change, or something, that needs to be investigated again.

I too am experiencing this. I have an older Model 3 and a newer Model Y. Today I just noticed that my Model 3 started showing up as null and ??? in Grafana and TeslaMate, respectively.

After restarting the containers, I checked the log, and I only see one instance of Starting logger for '<car name>', which was for the Model Y, and the name for the 3 is blank in the cars table. I manually updated it back to my nickname (but with (manual) at the end, just so that I know if/when it gets updated), but I suspect, from this discussion, that this may happen again later.

I also verified that my current tokens still allow me to see both vehicles, which it does. Also, the structure of the data, at least from /api/1/vehicles is the same for both vehicles. That said, I realize that TeslaMate is using the streaming API, but I am unsure on how to tap into that.

I also signed out TeslaMate and gave it the tokens I'm using now, and didn't seem to change it (this was before updating the database manually)

@prussell69
Copy link

My system was effected today, while I was watching it! Changed right before my eyes, so to say...
I also have 2 cars in the database, 1 active, 1 retired. The retired car retained it's name, while my active car changed to "???".
When I ran the query on the "cars" table, the name was blank for my active car.
Hopefully this will be corrected soon...
Whats bad, is my active car is #1, and the retired car is #2 in the database, and my active car is now listed 2nd on my dashboards, since the dashboards sort the cars by their names, not database number. arrgh!

@TMahlmann
Copy link

@adriankumpf bumping this as well as this issue has found its way to my machine / setup too. Getting "???" for my car names as well as "null" in grafana.
image

@CamIHelpYou
Copy link

+1 also just got affected by this issue today. From the timing of the comments it seems like some exponential rollout is breaking this.

@Nakatomi2010
Copy link

My cars are both on 2023.7.10, but have been for a couple weeks now.

I think it's a backend API change on Tesla's part.

@igeryu
Copy link

igeryu commented Jun 8, 2023

So, in continuation on my previous reply, even the newer car, Model Y, lost its name. However, when I took the containers down then back up again, both Starting logger for '<car name>' logs appeared again, and the names were back in the TeslaMate UI. 🤷‍♂️

@prussell69
Copy link

Yesterday I stopped/started my containers and the issue still remained. After reading igeryu's response this morning, I checked to see if the issue was still there, it was, so I tried the stopping/restarting again. Low and behold, the name came back!
What ever hiccup the API had, must have gone away. Hopefully everyone else has been corrected too. Thanks for everyones help in this issue...

@TMahlmann
Copy link

circling back to confirm now everything is fine after downing my containers and restarting them in Docker on my Synology with the UI buttons. Prob could do via SSH too but that was easier. Weird API hiccup then?

@mat1990dj
Copy link

I don't know, it is really strange. I took delivery of my 4th owned tesla yesterday and all the old ones which I no longer have retain their names, but the new one shows as ???. I've rebooted everything but it always comes as ???. VIN starts with 7SA, don't know if it's related.

@cwanja
Copy link
Collaborator

cwanja commented Jun 8, 2023

On a the non-edge version and can confirm that my vehicles name was randomly dropped from TeslaMate and confirmed through Grafana dashboards. I believe this to be a Tesla API hiccup as @prussell69 pointed out. I restarted my containers yesterday due to TeslaMate not responding and noticed the name was missing but did not put two and two together.

Just restarted the container (down and up commands) and it is not resolved. Tesla app is reporting the name and query against the owners API reflects the name. Assume TeslaMate will automatically update the cars entity at some point.

@cwanja
Copy link
Collaborator

cwanja commented Jun 8, 2023

Adding the name manually and then restarting containers drops the name manually added. Wonder if there was an API update that broken the ingestion of the car name from the API to TeslaMate.

@TMahlmann
Copy link

@adriankumpf I believe I have found the steps to reproduce the issue:

  1. Down/Up all teslamate containers with car asleep. Vehicle names reappear properly. (or appear) Grafana works with multiple vehicles and the correct names.
  2. Wake car(s) up by opening the Tesla app.
  3. Once cars wake up and connect to the API and TeslaMate notices this, the vehicle names disappear from TeslaMate and merge into a single "null" on grafana dashboards. "???" for each name on the standard :4000 teslamate settings page.
  4. Once cars fall back asleep, the names do not return but the proper logging does continue. If Teslamate is running, then you have the car(s) asleep, and restart all containers you can properly browse the data.

At some point after waking up, the names are erased from Teslamate?

@Nakatomi2010
Copy link

@adriankumpf I believe I have found the steps to reproduce the issue:

  1. Down/Up all teslamate containers with car asleep. Vehicle names reappear properly. (or appear) Grafana works with multiple vehicles and the correct names.
  2. Wake car(s) up by opening the Tesla app.
  3. Once cars wake up and connect to the API and TeslaMate notices this, the vehicle names disappear from TeslaMate and merge into a single "null" on grafana dashboards. "???" for each name on the standard :4000 teslamate settings page.
  4. Once cars fall back asleep, the names do not return but the proper logging does continue. If Teslamate is running, then you have the car(s) asleep, and restart all containers you can properly browse the data.

At some point after waking up, the names are erased from Teslamate?

This has been exactly my experience with it so far.

Works fine until the app re-establishes connection to the car, then it gets borked.

@igeryu
Copy link

igeryu commented Jun 8, 2023

@adriankumpf I believe I have found the steps to reproduce the issue:

  1. Down/Up all teslamate containers with car asleep. Vehicle names reappear properly. (or appear) Grafana works with multiple vehicles and the correct names.
  2. Wake car(s) up by opening the Tesla app.
  3. Once cars wake up and connect to the API and TeslaMate notices this, the vehicle names disappear from TeslaMate and merge into a single "null" on grafana dashboards. "???" for each name on the standard :4000 teslamate settings page.
  4. Once cars fall back asleep, the names do not return but the proper logging does continue. If Teslamate is running, then you have the car(s) asleep, and restart all containers you can properly browse the data.

At some point after waking up, the names are erased from Teslamate?

Not super helpful, but I can confirm that today the names went away again, but when I restarted the containers, it's now the newer vehicle, the Y that is still blank, but the 3 has its name again. The Y is awake and charging, the 3 is asleep, so this further corroborates the working-while-asleep behavior

@Nakatomi2010
Copy link

For what it's worth, as of this morning, my cars are reporting in properly now.

One car stopped talking to Tesla for about 25 hours, and as of a few minutes ago, it finally started working again, and when I logged into TeslaMate, I was able to see the names, though, Grafana still shows "Null". I haven't rebooted my containers yet, which I think will fix it.

Seems like some Tesla maintenance tomfoolery

@cwanja
Copy link
Collaborator

cwanja commented Jun 9, 2023

Can confirm the same, as of 12AM last night my cars name returned and has held through the night.

@cwanja
Copy link
Collaborator

cwanja commented Jun 9, 2023

Cars name is removed again. From the cars entity, the record was update at 2023-06-09 15:02:33 which was how long ago TeslaMate currently was attempting to fall asleep.

@llgiordano
Copy link

the names of my two cars disappeared today. They are on 2023.12.9.1 and 2023.12.9

@cjchand
Copy link

cjchand commented Jun 9, 2023

Registering a +1 on this, as well. Given the grouping of reports, I'm inclined to agree with @Nakatomi2010 - likely some API change. I updated them manually in the DB and Grafana shows both cars as expected.

@youzer-name
Copy link

++1. Mine disappeared again as of about 2023-06-09 15:00 EDT (UTC -4). I also updated the names manually in the DB and Grafana is working, although the Teslamate home page still doesn't show the names.

@aiden-cat
Copy link

I am affected by this as well. Reboot of teslamate will fix the issue but it apears again to set car names to null

@Cgmandy
Copy link

Cgmandy commented Jun 10, 2023

+1 For visibility. Car shows as ??? on teslamate, and as null on Grafana. Second vehicle not showing on Grafana. Vehicle has not had a chance to sleep yet though.

@weljajoh
Copy link

Same issue here as of today. I have two cars in the database, 1 retired, 1 still being used. The latter now shows up as 'null' in Grafana.

@LukeSkywalker993
Copy link

LukeSkywalker993 commented Jun 10, 2023

I have the same problem.
The vehicle name is no longer displayed. Now only the model is on the main page and the Grafana says "null"

Restarting the Docker container didn't help

grafik

grafik

@merlinfive
Copy link

noticed the same today , yesterday updated to 2023.12.300.1 , Teslamate running on synology , after container restart the name shows up again

@LukeSkywalker993
Copy link

when I restart docker, the name of the vehicle comes back every now and then.
The name was just visible for almost 20 minutes, but then disappeared again.

@drjjr2
Copy link

drjjr2 commented Jun 10, 2023

And here I thought the problem was related to the power outages we had here in Houston yesterday. Guess I will stop trying to figure out what is wrong on my end if so many others are seeing the same thing.

@DFOUD
Copy link

DFOUD commented Jun 10, 2023

I have the same problem, I am using the latest release 1.27.2, I have two cars, after adding the second car to teslamate, it shows two "???" in teslamate. and the data of the first car in grafana is all gone, only the second car is there instead, and it shows as null.
Please tell me that my data is not lost and is still being recorded, I just can't view it at the moment. pls
IMG_4515
IMG_4514

My native language is not English and I am using a translation software

@RafaG
Copy link

RafaG commented Jun 10, 2023

Same problem here, I only have one car, and now thd car's name is null

@netkruzer
Copy link

I have the same problem. If I restart teslamate on my recently updated Ubuntu install, I see the names of the cars correctly. If I wait a while, I think if I drive one for a bit, and look later, it turns back to null for one car, and the other car is missing completely.

I hope this is a quick/easy fix.

@agrdbf
Copy link

agrdbf commented Jun 10, 2023

I can confirm as well. Can't say till when. But after checking grafana stats after a some time, I recognized that the cars name is gone. The name of the retired M3 is still there. It is also gone from the db.

screensho02

Everything else seems to work properly.
I'm on teslmate 1.27.1 and since 19.05. on 2023.12.9. But I can't tell if the Tesla update has something to do with this issue.

But like always happy I'm not the only one with this issue. Looking forward for a fix.

@krelltunez
Copy link

Experiencing this as well starting in the last few days. Names come back if I restart the containers while cars are sleeping. If one or both is awake (or subsequently wakes) the names reset to null.

The good news is Teslamate is still recording drives, charges, etc.

@Syncena
Copy link

Syncena commented Jun 11, 2023

Looks like Tesla changed the API. Another GitHub project has found the root cause.

@merlinfive
Copy link

looks like the information was just "moved" somewere else so should be possible to fix easily

image

@pkuehnel
Copy link

@ebringas Please update your first post including the title as this issue does not only occur if the cars have no names. My two cars have a name and I have the same issue.

@dedg3
Copy link

dedg3 commented Jun 11, 2023

It's already fixed. Just wait for the next Release 👍

6af97ba

@Nakatomi2010
Copy link

1.27.3 was released about an hour ago, I've updated my TeslaMate instance, and I see the issue resolved now.

Thanks.

@MrNickIE
Copy link

1.27.3 was released about an hour ago, I've updated my TeslaMate instance, and I see the issue resolved now.

Thanks.

You say this is fixed, but I am still seeing the same on an unnamed car in our fleet. We have 5 cars, and the only one showing NULL is the one that the user didnt set a name. Is that issue still expected?

@Nakatomi2010
Copy link

Nakatomi2010 commented Jun 20, 2023 via email

@MrNickIE
Copy link

It is fixed for me still.

On Tue, Jun 20, 2023, 3:35 PM NW @.> wrote: 1.27.3 was released about an hour ago, I've updated my TeslaMate instance, and I see the issue resolved now. Thanks. You say this is fixed, but I am still seeing the same on an unnamed car in our fleet. We have 5 cars, and the only one showing NULL is the one that the user didnt set a name. Is that issue still expected? — Reply to this email directly, view it on GitHub <#3183 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGHLBEL2PEHRJ3TEGW23E5LXMH3RLANCNFSM6AAAAAAW64VUPI . You are receiving this because you were mentioned.Message ID: @.>

Thanks, and to confirm, your car does NOT have a set name?

I am fine now on 4 our of 5 cars.

@Nakatomi2010
Copy link

Nakatomi2010 commented Jun 20, 2023 via email

@cwanja
Copy link
Collaborator

cwanja commented Jun 20, 2023

1.27.3 was released about an hour ago, I've updated my TeslaMate instance, and I see the issue resolved now.

Thanks.

You say this is fixed, but I am still seeing the same on an unnamed car in our fleet. We have 5 cars, and the only one showing NULL is the one that the user didnt set a name. Is that issue still expected?

If you have no name set, yes the expected value is NULL if you are running the latest version of TeslaMate. I do not believe the API would report 'Tesla Model S' or whatever the default value is when you get a new car.

Had the issue until I upgraded. After upgrading, it was fixed immediately and never regressed.

@alfiepowers1138
Copy link

If it helps, I noticed both our cars had lost their names in the car's information panel. However, they both still showed correctly on my phone. Renaming or adding the names, then down/up teslamate solved my issue. No more nulls or merged cars for me.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Dec 1, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests