Examples contain misleading version restrictions

[OurFriendIrony]

Some of your examples reference the sts module terraform-redhat/rosa-sts/aws.
This module has a restriction to only support version 4.x.x of terraform, not >4.
Whilst that is not related to this provider directly, this projects examples show >= 4.x.x as being allowed.

I am currently using 5.x.x but cannot follow the examples due to the restriction in the sts module. I have raised an issue last week on that repo but have not met a response yet. terraform-redhat/terraform-aws-rosa-sts#23

[nirarg]

Hi @OurFriendIrony ,
Thank you for the feedback
We work on improving the examples, targeting this as well

[OurFriendIrony]

Has any progress been made on this? I believe the module issue still hasn't received any responses highlighting any future changes

[nirarg]

Hi @OurFriendIrony ,

We are working on new module which also is going to contain all examples with improvements.
This is the new repository opened for this purpose:
https://github.com/terraform-redhat/terraform-rhcs-rosa
We will update here when this new module will be published

[OurFriendIrony]

Will this deprecate terraform-redhat/terraform-aws-rosa-sts#23 ?

[nirarg]

Hi @OurFriendIrony
Yes, finally the old module will be deprecated

If you need it for now, I can create quick fix changes the AWS version to ">=4.x.x", and release special module tag for this
You will have to change the module source version manually in the examples you use
In case you want this change, what is the module version you use?

[OurFriendIrony]

No it is fine, I can move over to the new module. Thanks.

…

On Wed, 20 Sept 2023, 13:40 Nir Argaman, ***@***.***> wrote: Hi @OurFriendIrony <https://github.com/OurFriendIrony> Yes, finally the old module will be deprecated If you need it for now, I can create quick fix changes the AWS version to ">=4.x.x", and release special module tag for this You will have to change the module source version manually in the examples you use In case you want this change, what is the module version you use? — Reply to this email directly, view it on GitHub <#207 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7MONS4ZCHJCAZ6HUJJQK3X3LP47ANCNFSM6AAAAAA2RRBZXM> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[nirarg]

This was fixed in rosa-sts module in version 0.0.14
Also new module is in work in progress already with this issue solved

Closing this issue