-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue in TFX Transform component after upgrade it from 0.22 -> 0.24.1 #2668
Comments
After downgrade it to v0.23.1, it works. So i suspect there might be some bugs inside Transform component for v0.24.1 |
Is there a colab notebook that we can use to repro this issue? |
Hi @zoyahav , I see the same issue as @sakinaljana reported, but not in all pipelines. Pipeline with a failing TFT component: I doubt that this is an issue, but just in case: The working example ingests the data with the |
The failing example I have ingests from BigQuery. |
Thanks everyone, I've confirmed on the first colab in #2668 (comment) that disabling cache prevents this issue and Transform succeeds (as a temporary workaround):
I'll look for the root cause and hopefully make a patch release with a fix. |
Thanks @zoyahav - that works for me. |
Btw, the issue should be fixed on latest tfx nightly with e6c3d05 merged. See: |
@zoyahav - I'm still getting the same behaviour - was the fix included in last night's build? |
I've verified that the provided repro notebook in #2668 (comment) with the latest nightly tfx version (0.25.0.dev20201028) is now working. @mshearer0 could you please verify which version of TFX you're running with and confirm that you're seeing the same error as before? |
@zoyahav - I’m running tfx 0.24.1 with the example from: https://github.com/GoogleCloudPlatform/ml-design-patterns/blob/master/06_reproducibility/storm_reports/similar_reports.ipynb Nb: see GoogleCloudPlatform/ml-design-patterns#17 And fix for type error in last comment at: |
As mentioned tfx 0.24.1 still has the issue present, only on the nightly version is the issue fixed. The latest nightly can be install by running |
@zoyahav - yes, I’ve pip installed the nightly update on 0.24.1 base |
@zoyahav I have tested one pipeline with the tfx-nightly release (0.25.0.dev20201028) and it works on my side. @mshearer0 After installing the tfx nightly version, you should see a version number like 0.25.0.dev ... You can check the version number with
If you see a version number like 0.24.1 or lower,
|
Thanks @hanneshapke - Pip wasn't updating properly and i hadn't spotted it, forcing with -U gives 0.25.0.dev20201028. @zoyahav - works now, thank you. |
Thank you both for verifying. I believe we can close this issue once 0.25 is released. |
I think we can close this since already solved in 0.25 |
The implementation works for me on version 0.25. Thank you all for the updates! |
Hello folks,
Recently i'm trying to upgrade the TFX version to the latest (v0.24.1) from the old one (v0.22). I didn't change anything in the pipeline code, just pure library upgrade. After running the pipeline, found following issue inside Transform component:
Any idea why this happened? seems Transform component want to iterate the item but not found, hence throw
StopIteration
. It works well with v0.22. Thanks in advance!The text was updated successfully, but these errors were encountered: