Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset should be allowed with pending childWF in current run, if current run is already closed #3624

Open
longquanzheng opened this issue Nov 19, 2022 · 4 comments
Assignees

Comments

@longquanzheng
Copy link
Contributor

return nil, serviceerror.NewInvalidArgument("WorkflowResetter encountered pending child workflows.")

Mirror issue cadence-workflow/cadence#5030

This is because child WF could get get closed after parent closed, and parent will not receive the children close signals.

So that after parent is closed for any reasons(terminate/timeout/fail/etc), this parent is never allowed to reset to anywhere because it has a pending childWFs in its mutableState forever as "deadlock condition"

@yiminc yiminc self-assigned this Nov 20, 2022
@sync-by-unito sync-by-unito bot closed this as completed Mar 3, 2023
@yiminc yiminc reopened this Mar 3, 2023
@taonic
Copy link

taonic commented Jun 6, 2023

Relates to #705

@MalteHB
Copy link

MalteHB commented Jan 5, 2024

Any updates on this @yiminc?

I am also encountering that a workflow, without any pending children, cannot be reset to anything else but the first WorkflowTaskCompleted due to the WorkflowResetter encountered pending child workflows. error.

@yujiachen-y
Copy link

Hi @yiminc , do we have any plans to address this issue? I'm also stuck on this problem.

@snackattas
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants