Fix the documentation of ListWorkflow for querying open workflows #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Quinn-With-Two-Ns
force-pushed
the
eigenvariable/fix_comment
branch
from
7fa9821 to
9f8d3a1
Compare
Quinn-With-Two-Ns
approved these changes
Aug 30, 2023
Quinn-With-Two-Ns
force-pushed
the
eigenvariable/fix_comment
branch
from
9f8d3a1 to
fa67971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This fixes the documentation around using
ListWorkflowfor querying open workflows.Why?
The comment appeared to be incorrect, at least WRT temporal cloud.
CloseTime = missingdoesn't appear to be a valid query, whereasCloseTime is nullseems to do what you'd expect.Checklist
Closes
How was this tested:
This is just a change to a comment. I tested the accuracy of the documentation via trial and error (also via the Temporal Cloud web UI).