Add test for child wf cancel and update #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Aug 29, 2023
Quinn-With-Two-Ns
force-pushed
the
test-child-wf-cancel
branch
from
8a56162 to
f060de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexshtin Reported a non determinism in a test tool. The failings workflow event history was very long, but the section that failed was similar to
child-workflow-cancel-with-update.json. Specifically the sequence of eventsWorkflowTaskCompleted,RequestCancelExternalWorkflowExecutionInitiated,WorkflowExecutionUpdateAccepted,ActivityTaskScheduledwas causing non determinism about activity ID mismatch. The root cause was a Go SDK counting bug because the SDK was not accounting for the command that resulted inRequestCancelExternalWorkflowExecutionInitiatedbecause the command was not being generated when the workflow was cancelling.I already, unintentionally, fixed this bug in this commit. If you try to run this history on an older SDK release it will fail because the SDK is not counting the command that resulted in
RequestCancelExternalWorkflowExecutionInitiatedI created this test as a replay test because I could not reliably generate the scenario that causes this sequence of events with an integration test so I manually wrote this history.