Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debt: better understand how changing depth interval presets works in the soilDataPush mutation #1527

Open
shrouxm opened this issue Oct 31, 2024 · 0 comments

Comments

@shrouxm
Copy link
Member

shrouxm commented Oct 31, 2024

Notes from the original soilDataPush PR:

  • depth interval presets are weird. i think i understand why we manually delete all depth intervals when we change presets, but since this is now happening in simultaneously with other operations it raises some questions:
    • should we do that deletion before or after applying other depth interval related changes? i implemented "before"
    • should we just not implement this server-side and rely on clients to send the appropriate set of depth intervals to delete? it seems like we'd be more likely to end up with the client's intended data this way, but not sure how that interacts with concurrent changes. but now that i'm writing this out, i'm thinking that since we're recommending to early users to not make concurrent changes we should prioritize user intent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants