Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Code #83

Open
12Jeef opened this issue Apr 6, 2024 · 3 comments
Open

Better Code #83

12Jeef opened this issue Apr 6, 2024 · 3 comments
Labels
app Related to PeninsulaPortal directly bug Something isn't working

Comments

@12Jeef
Copy link
Member

12Jeef commented Apr 6, 2024

Observed:

  • Variable names are single letter, or have no unit descriptor

Expected:

  • Probably more than single letter, and have a unit descriptor when unclear
@12Jeef 12Jeef added bug Something isn't working app Related to PeninsulaPortal directly labels Apr 6, 2024
@12Jeef
Copy link
Member Author

12Jeef commented Apr 6, 2024

Note: this will probably change a lot of code...

@12Jeef
Copy link
Member Author

12Jeef commented May 11, 2024

Probably need comments too

@12Jeef
Copy link
Member Author

12Jeef commented May 31, 2024

Probably need to split classes into separate files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Related to PeninsulaPortal directly bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant