Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor [#242] 추천친구 리팩토링 #268

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Refactor [#242] 추천친구 리팩토링 #268

wants to merge 16 commits into from

Conversation

chaentopia
Copy link
Collaborator

⛏ 작업 내용

  • 추천친구와 검색 부분 리팩토링 진행했습니다.
  • 전반적인 구조를 바꾸는 건 어려울 것 같아서.. 우선은 불필요한 코드 삭제와 간단한 수정을 진행했습니다.

📌 PR Point!

  • x

📸 스크린샷

구현 내용 스크린샷
화면종류 x

✅ Issue

Resolved #242

@chaentopia
Chore [#242] 추천 탭 폴더링 변경
826feca
@chaentopia
Chore [#242] 마크 주석 추가
4ff0af7
@chaentopia
Refactor [#242] 추천 친구 스켈레톤 뷰 고차함수 리팩
bf409ab
@chaentopia
Merge branch 'fix/#246-searchFix' into refactor/#242-recommendRefactor
34153b0
@chaentopia
Refactor [#242] 추천친구 BaseVC 변경
d245f6e
@chaentopia
Chore [#242] 클래스 설명 추가
c17d0cb
@chaentopia
Refactor [#242] StringLiterals 사용 수정
d94f635
@chaentopia
Refactor [#242] StringLiterals 사용 수정 추가
9fb168a
@chaentopia
Refactor [#242] skeletonTableViewCell 고차함수로 변경
40f950f
@chaentopia
Chore [#242] 파일에 대한 설명 추가
f5673bb
@chaentopia
Chore [#242] 로티 폴더링 변경
dd1c44b
@chaentopia
Refactor [#242] BaseView / BaseVC 변경
015dd66
@chaentopia
Fix [#242] 추천친구 친구 추가 버튼 색상 수정
9c09ade
@chaentopia
Refactor [#242] BaseView로 변경
058f30a
@chaentopia
Refactor [#242] 친구초대뷰 불필요한 코드 삭제
3234601
@chaentopia chaentopia self-assigned this Oct 25, 2023
Zoe0929
Zoe0929 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@Zoe0929 Zoe0929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5
전체적으로 중복되는 코드들을 foreach 사용해서 간결하게 작성한 게 좋네요!!
고생하셨습니다. 구조를 바꾸는 건 다시 또 얘기해서 적용해보는 게 좋을 것 같아요 💖💖 파이팅 🔥

Heyjooo
Heyjooo approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@Heyjooo Heyjooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5
수고하셨습니다!~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heyjooo Heyjooo Heyjooo approved these changes

@Zoe0929 Zoe0929 Zoe0929 approved these changes

Assignees

@chaentopia chaentopia

Labels
refactor 채은🎐
Projects
YELL:O iOS
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] 추천친구 및 검색 리팩토링
3 participants
@chaentopia @Zoe0929 @Heyjooo