Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A param of type 'List' is breaking camelCase() #10

Open
chrisbuttery opened this issue Apr 4, 2016 · 7 comments
Open

A param of type 'List' is breaking camelCase() #10

chrisbuttery opened this issue Apr 4, 2016 · 7 comments

Comments

@chrisbuttery
Copy link
Contributor

It seems a List is being passed through the camelCase instead of a string.

Closed PR: #9 (comment)

screen shot 2016-04-04 at 5 16 40 pm

@makenosound
Copy link
Contributor

@chrisbuttery Yeah, so the likely cause is that the formalist AST doesn’t match what we’re expecting somewhere. Can you work out which field/section/group etc combination is causing that error?

I think throwing an error when the value isn’t a String here is totally reasonable, makes it clearer what’s going on.

@chrisbuttery
Copy link
Contributor Author

@makenosound I've just addressed this in PR #13

@makenosound
Copy link
Contributor

@chrisbuttery Cool, thanks!

@timriley
Copy link

We should keep this open to make sure we work out and prevent the original issue about the wrong data being passed to the camel case function, yes?

@makenosound
Copy link
Contributor

@timriley I think it was just old AST data.

@timriley
Copy link

Ah, OK then!

@chrisbuttery
Copy link
Contributor Author

@makenosound @timriley Yeah I believe it was. I'll leave open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants