Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use Vite? #1680

Open
hal-shu-sato opened this issue Feb 11, 2024 · 1 comment
Open

Change to use Vite? #1680

hal-shu-sato opened this issue Feb 11, 2024 · 1 comment
Labels
0: help wanted Extra attention is needed Feedback: enhancement New feature or request Type: improvement Improvements to program

Comments

@hal-shu-sato
Copy link
Member

Is your feature request related to a problem? Please describe.

Electron Forge now supports Vite.
It is ok to change the compile system to Vite, I think.

I heard VIte is easy to configure and superior regarding hot reload.
But I heard before that Vite doesn't have type-checking.

Describe the solution you'd like

Migrate to Vite.

Describe alternatives you've considered

Continue using Webpack.

Additional context

@hal-shu-sato hal-shu-sato added Feedback: enhancement New feature or request 0: help wanted Extra attention is needed Type: improvement Improvements to program labels Feb 11, 2024
@yumetodo
Copy link
Contributor

yumetodo commented Feb 19, 2024

Type-check should be executed outside of build process. For example, we can just call tsc --noEmit for type check.

Or, if you want more rich support for type check, you can use vite-plugin-checker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0: help wanted Extra attention is needed Feedback: enhancement New feature or request Type: improvement Improvements to program
Projects
None yet
Development

No branches or pull requests

2 participants