Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused AO CreateAsyncIteratorFromClosure #3509

Open
michaelficarra opened this issue Dec 18, 2024 · 2 comments
Open

remove unused AO CreateAsyncIteratorFromClosure #3509

michaelficarra opened this issue Dec 18, 2024 · 2 comments

Comments

@michaelficarra
Copy link
Member

It's unused. We should simply delete it.

@ljharb
Copy link
Member

ljharb commented Dec 18, 2024

It was added in #2045, in the pursuit of built-in generators, for async iterator helpers. Will async iterator helpers use it? If so, it's probably best not to create more churn by removing it; if not, it should ofc be axed.

@bakkot
Copy link
Contributor

bakkot commented Dec 18, 2024

Will async iterator helpers use it?

No, since the concurrency stuff they're trying to do doesn't work with generators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants