Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ruby 2.0 #75

Open
jims3ne1 opened this issue Jul 8, 2013 · 3 comments
Open

Support for ruby 2.0 #75

jims3ne1 opened this issue Jul 8, 2013 · 3 comments

Comments

@jims3ne1
Copy link
Contributor

jims3ne1 commented Jul 8, 2013

Is this compatible with ruby 2.0? We tested it, it seems fine but just wondering if there's anything we should be aware of.

@tc
Copy link
Owner

tc commented Jul 8, 2013

I have not tested it myself but if anyone else is using it with 2.0, please
comment here.
On Jul 8, 2013 4:53 AM, "jimbocortes" [email protected] wrote:

Is this compatible with ruby 2.0. We tested it, it seems fine but just
wondering if there's anything we should be aware of.


Reply to this email directly or view it on GitHubhttps://github.com//issues/75
.

@rchekaluk
Copy link
Contributor

I have found that paypal_adaptive 0.3.6 send_back fails to validate a Paypal IPN under ruby-2.0.0-p353, yet validates just fine under ruby-1.9.3-p484.

Don't know if it's relevant or not but in another gem, I encountered this Net::HTTP incompatibility (and successfully utilized the monkey patch); there could be other Net::HTTP changes in ruby 2.0 that are affecting paypal_adaptive.

Update: It's possible that this issue is limited to Heroku apps.

@rchekaluk
Copy link
Contributor

Under ruby-2.0.0-p353, I found that the PaypalAdaptive::Request.preapproval POST response is binary data; since this cannot be parsed as JSON, preapproval returns an error message of "Response is not in JSON format."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants